SpellReminder

16 - Potholes encountered on the Ace3 road

What steps will reproduce the problem?

1. Log on after upgrading from r210 to v3.0

2. After fixing the above problem (see below), log on again and try to disable, then enable a 60 minute buff through the options: Fire Festival Fortitude (on due to the WoW holidays).

What is the expected output? What do you see instead?

Expected: no issues for 1. and for 2., the spell to disable and reenable when checkmarking the "Enabled" option for it.

Instead: on first logon after upgrading, an error is thrown and the mod no longer functions. After fixing that issue by deleting the saved variables and trying again, encounter the second problem. The spell(s) you checkmark to enable or disable tracking of don't pay attention to the state of the checkmark until you relog.

What version of the product are you using?

v3.0

Do you have an error log of what happened?

For the first issue:

["message"] = {
				"SpellReminder-3.0\\core.lua:455: table index is nil\nSpellReminder-3.0\\core.lua:424: in function `AddNewAnchor'\nSpellReminder-3.0\\core.lua:447: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:424: in function `AddNewAnchor'\nSpellReminder-3.0\\core.lua:443: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:355: in function `OnProfileEnable'\nSpellReminder-3.0\\core.lua:280: in function <Interface\\AddOns\\SpellReminder\\core.lua:279>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):543: in function `EnableAddon'\nAceAddon-3.0-10 (Ace3):635: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n<in C code>: in function `LoadAddOn'\nInterface\\FrameXML\\UIParent.lua:259: in function `UIParentLoadAddOn':\nInterface\\FrameXML\\UIParent.lua:282: in function `CombatLog_LoadUI':\nInterface\\FrameXML\\UIParent.lua:558: in function <Interface\\FrameXML\\UIParent", -- [1]
				".lua:531>:\n", -- [2]
			},
			["type"] = "error",
			["session"] = 3113,
			["counter"] = 1,
		}, -- [997]

No errors for the second issue.

Please provide any additional information below.

As the first issue was fixed by deleting (both the root and individual character) saved variables from the Ace2 SpellReminder, it says that no upgrade code is in the mod. Logging on after the upgrade, it shows you two anchors on the screen as well as throwing up the error. Nothing further can be done; the options can't be accessed and no spells are tracked.

You don't want people upgrading to run into this bug, so three alternatives.

- - The easiest way is just to say "you must delete all your prior SpellReminder saved variables before logging on with the new Ace3 version". Very much a hassle for users who spent a great deal of time setting up the Ace2 version the way they wanted. All that time spent goes up in smoke.

- - Second option is also undesirable: have the mod automatically reset the saved variables on logon from an older version so it doesn't bugout.

- - Third option is the best: provide a one-time upgrade mechanism/SV interpreter so that people can continue to use their old saved variable settings that they may have spent a great deal of time setting up. Bar positions, what spells to track and not track and so on. Its the most code for you to do this, but the hours of time saved for people not having to set things up from scratch from will benefit society the most ;).

The second problem is enough to make me go back to the Ace2 version for now. The old version instantly hid spells when you set them to "inactive" and showed them again when you changed them to "active". v3.0 doesn't do that. Once you remove the checkmark from Enabled for a spell, the spell bar remains onscreen until you relog. Same deal checkmarking a spell's Enabled to make it active when its in the Inactive header section; you have to relog to see it again..

Having to relog to change the active status of spells is a monumental ongoing hassle. More and more so the more database mods you run and/or the slower the computer you have, as both of those slow down your relogs. Its so much of a hassle here that I'm back to the Ace2 version.

Great idea to port this to Ace3, but hope to see these two issues fixed.

User When Change
Zidomo Aug 28, 2011 at 19:39 UTC
Zidomo Aug 28, 2011 at 12:00 UTC
Zidomo Aug 05, 2011 at 18:59 UTC
oridan Aug 04, 2011 at 06:48 UTC
Zidomo Aug 04, 2011 at 03:30 UTC
oridan Jul 31, 2011 at 20:40 UTC
Zidomo Jul 27, 2011 at 14:02 UTC
Zidomo Jul 23, 2011 at 11:53 UTC
Zidomo Jul 23, 2011 at 11:51 UTC
oridan Jul 22, 2011 at 09:14 UTC
oridan Jul 22, 2011 at 08:51 UTC
Zidomo Jul 19, 2011 at 17:47 UTC
oridan Jul 19, 2011 at 07:14 UTC
Zidomo Jul 19, 2011 at 02:27 UTC
oridan Jul 18, 2011 at 22:08 UTC
oridan Jul 16, 2011 at 13:53 UTC
Zidomo Jul 16, 2011 at 07:45 UTC
Zidomo Jul 16, 2011 at 06:44 UTC
oridan Jul 15, 2011 at 19:44 UTC
oridan Jul 15, 2011 at 19:44 UTC
Zidomo Jul 15, 2011 at 09:39 UTC
oridan Jul 14, 2011 at 09:49 UTC
Zidomo Jul 14, 2011 at 09:36 UTC
oridan Jul 13, 2011 at 20:22 UTC
Zidomo Jul 12, 2011 at 23:54 UTC
Zidomo Jul 12, 2011 at 23:33 UTC
oridan Jul 11, 2011 at 20:35 UTC
oridan Jul 11, 2011 at 17:11 UTC
Zidomo Jul 07, 2011 at 09:47 UTC
Zidomo Jul 07, 2011 at 09:46 UTC
Zidomo Jul 07, 2011 at 09:02 UTC
Zidomo Jul 07, 2011 at 09:02 UTC
Zidomo Jul 07, 2011 at 09:01 UTC
oridan Jul 06, 2011 at 13:30 UTC
oridan Jul 04, 2011 at 20:50 UTC
Zidomo Jul 03, 2011 at 23:42 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Zidomo Zidomo Aug 28, 2011 at 12:00 UTC - 0 likes

    Haven't tested very much further importing; at this stage, it pretty much doesn't matter for the bulk of users. One bug with it still seen, however.

    A Paladin respeced into protection (tanking) for the first time since Lich King. Had "Crusader" as a tracked buff cooldown (its a spell effect from the talent Crusade). Bugged out and the following error was thrown & repeated throughout a 5-man instance run. It was placed on the default Normal & Emphasis bars, the bars were not changed or moved:

    ["message"] = "LibBars-1.0-90013 (LibBars-1.0):589: Cannot move SpellReminder_TRACKING_Crusader;0x0200000003A82B3B to this group; a bar with that name already exists.\nLibBars-1.0-90013 (LibBars-1.0):589: in function `MoveBarToGroup'\nSpellReminder-3.0\\core.lua:968: in function `CreateReminderBar'\nSpellReminder-3.0\\core.lua:898: in function <Interface\\AddOns\\SpellReminder\\core.lua:875>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":9: in function <[string \"safecall Dispatcher[2]\"]:5>\n(tail call): ?:\nAceTimer-3.0-5 (Ace3):164: in function <Interface\\AddOns\\Ace3\\AceTimer-3.0\\AceTimer-3.0.lua:138>\n",
    			["type"] = "error",
    			["session"] = 3925,
    			["counter"] = 10,
    		}, -- [1000]
    
  • Avatar of Zidomo Zidomo Aug 04, 2011 at 20:58 UTC - 0 likes

    With r258 (upgrading from r251 saved variables), a lot is fixed, but not everything. On the single custom bar here (along with the other bars) the proper font, scaling & texture were imported correctly and correctly shown in the dropdown selections.

    But on the custom bar, the previously selected custom sound was not imported correctly. Instead of the "BeepBeepBeep" sound previously selected, it mysteriously chose "CartoonFX".

    Last edited Aug 05, 2011 by Zidomo
  • Avatar of oridan oridan Aug 04, 2011 at 08:18 UTC - 0 likes

    I've a routine to fix the saved variables and tested it with old v2 saves and the old v3 saves. it seems to be working for me, could you try it? Thanks!

  • Avatar of oridan oridan Aug 04, 2011 at 06:48 UTC - 0 likes

    the first implementation of ace3config was badly done on my part, this caused boxes to be blank on upgrading from version2. this new method is compatible with the version2 saves, but anyone who has been using version 3 will now get blank boxes again. i can write a "version3 to new version3 import", that shouldn't take long :)

  • Avatar of Zidomo Zidomo Aug 04, 2011 at 01:20 UTC - 0 likes

    In addition to the more serious issue with r255 in the other ticket, another one will put there.

    Have not tested Ace2 SV importing with yet, but in terms of upgrading from a pre-AceGUI-3.0-SharedMediaWidgets version (r251 used before here), it experiences the exact same problem...heh. Most all dropdown selections are blank after logging on with a r255 upgrade.

  • Avatar of Zidomo Zidomo Aug 03, 2011 at 19:20 UTC - 0 likes

    Ah interesting. Moreso that it requires another library to do that. No problem, though; AceGUI-3.0-SharedMediaWidgets is a very widely used library with no history of problems.

    Yes, with two considerations for using old settings, more problems have the potential for appearing than with one. As in: 1) "import" & interpret the old settings and 2) convert those settings to the currently used format. Elimination of 2) can certainly remove one potential for problems.

    Have not tested importing since r245, will again soon.

  • Avatar of oridan oridan Aug 03, 2011 at 10:23 UTC - 0 likes

    fixed in r253 by making use of AceGUI-3.0-SharedMediaWidgets - no version 2 SV import required, as this change reverts to using the same save format as spellreminder v2 for sharedmedia options.

  • Avatar of oridan oridan Jul 31, 2011 at 20:40 UTC - 0 likes

    Ill try to get this fixed asap :)

  • Avatar of Zidomo Zidomo Jul 27, 2011 at 14:02 UTC - 0 likes

    Bad news (& a bit of good) with the importing of Ace2 SVs with r245. Custom bars attached to spells and their locations are properly imported. But lots of things are not.

    The dropdown selections for General, Text Warnings along with Texture and Font under Bar Formatting as well as Allow Custom Sound under particular spells (it is set for) are all blank after logging on, much like earlier versions.

    Last edited Jul 27, 2011 by Zidomo
  • Avatar of Zidomo Zidomo Jul 26, 2011 at 16:14 UTC - 0 likes

    Yes, nice work. r245 completely solves the enabling/disabling. Bars now go away immediately after disabling and come back immediately after enabling.

    Import testing still to come, again ;).

Facts

Last updated
Aug 28, 2011
Reported
Jul 03, 2011
Status
Waiting - Waiting for more information.
Type
Defect - A shortcoming, fault, or imperfection
Priority
High - Strongly want to resolve in the specified milestone.
Votes
0

Reported by

Possible assignees