WowAce.com

Skillet

80 - Tradeskill linking broken in patch 3.3.5

What steps will reproduce the problem?
1. Patch WoW to 3.3.5
2. Try to link your tradeskill in chat
3. Behold the error

Ultimately, ChatFrameEditBox went away in Patch 3.3.5 and was replaced with individual ChatFrameNEditBox-es where N is the index of the ChatFrame, this is causing havoc among many addons that interacted with the ChatFrameEditBox, including yours.  I've patched my local copy to where linking is working again, it isn't very elegant, but it works.  I've attached the patch in case you want to incorporate or modify my changes in the trunk.

Hirsute

Name Description Size MD5
skillet-chatbox-fix.diff diff of my changes to skillet ... 1.4 KiB 4b76fafb5b1c...
User When Change
lilsparky Jun 25, 2010 at 17:09 UTC Changed status from New to Fixed
Hirsute Jun 25, 2010 at 14:29 UTC

Added attachment skillet-chatbox-fix.diff
Hirsute Jun 25, 2010 at 14:25 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of lilsparky lilsparky Jun 25, 2010 at 17:04 UTC - 0 likes

    they finally did something that actually breaks skillet. and here i was thinking that gnomeworks would make it out before i had to monkey with skillet.

    ChatEdit_GetLastActiveWindow()

    tells you which edit box to use apparently.

  • Avatar of Hirsute Hirsute Jun 25, 2010 at 14:38 UTC - 0 likes

    I failed to mention, this patch is to Skillet/UI/MainFrame.lua

  • 2 comments

Facts

Last updated
Jun 25, 2010
Reported
Jun 25, 2010
Status
Fixed - Developer made requested changes. QA should verify.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees