Skillet

245 - TradeSkillLink has changed format causing errors

What version of the product are you using?

2.43

Do you have an error log of what happened?

Date: 2013-05-21 21:11:14
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Skillet\SkilletData.lua line 704:
   attempt to concatenate local 'maxRank' (a nil value)
Debug:
   [C]: ?
   Skillet\SkilletData.lua:704
      Skillet\SkilletData.lua:701
   (tail call): ?
   Skillet\SkilletData.lua:2229 GenerateAltKnowledgeBase()
   Skillet\SkilletData.lua:2332 RecipeGroupGenerateAutoGroups()
   Skillet\SkilletData.lua:1711 RescanTrade()
   Skillet\SkilletData.lua:1585 RescanTrade()
   Skillet\SkilletData.lua:1490 ?()
   ...ns\TradeskillInfo\Libs\AceTimer-3.0\AceTimer-3.0.lua:41
      ...ns\TradeskillInfo\Libs\AceTimer-3.0\AceTimer-3.0.lua:36
Locals:

Please provide any additional information below.

Major changes to TradeSkillLink. See http://www.wowpedia.org/TradeSkillLink for details.

The above error can be fixed by changing line 703 to:

        local _,_, guid, tradeID, rank, maxRank = string.find(Skillet.db.realm.linkDB[player][trade], "trade:(%d+):(%d+):(%d+):(%d+)")

but a search for "trade:" shows many other changes will be needed.

User When Change
hotZED Sep 16, 2013 at 10:49 UTC
bsmorgan May 22, 2013 at 03:40 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Conhunter Conhunter May 26, 2013 at 02:34 UTC - 0 likes

    @smccandl: Go

    Thank You smccandl. The hotfix worked perfectly.

  • Avatar of smccandl smccandl May 23, 2013 at 00:31 UTC - 0 likes

    I love Skillet so much I decided to see if I could fix it myself... :) Here is what I found. Line 703 in SkilletData.lua seems to be fetching data from the "database" entry "Skillet.db.realm.linkDB[player][trade]". When I check the contents of that entry I get what looks like this "|cffffd000|Htrade:5000000003FACDA:104381:600:600:2/7/7/9f/97//D++93n/5/D:982:0:0:A:981:0:0:A:980:600:600:/A:979:575:600:7:978:580:600:7:977:600:600:7:976:600:600:/:975:600:600:/|h[Cooking]|h|r". The string.find is searching using this pattern "trade:(%d+):(%d+):(%d+)", however the first set of data after the string "trade:' is HEX (%x+) and not DECIMAL (%d+). I changed line 703 to be the following and all errors have been cleared! Thanks for a GREAT addon! Keep up the good work.

    local _,_,tradeID, rank, maxRank = string.find(Skillet.db.realm.linkDB[player][trade], "trade:(%x+):(%d+):(%d+)")
    
  • 2 comments

Facts

Last updated
Sep 16, 2013
Reported
May 22, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees