Skillet

114 - Sorting|By Beancounter

The Beancounter info in the recipe info window is awesome.  (Ironically, I find it more useful than the Beancounter windows.)  That's the inch, here's the mile: Can a sorting option be added to sort by the displayed gold earned (30-day) value?

User When Change
bsmorgan May 19, 2014 at 16:47 UTC Changed status from Accepted to Declined
yossa Nov 13, 2010 at 18:13 UTC Changed status from New to Accepted
RoloX2 Nov 13, 2010 at 16:55 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 7 comments
  • Avatar of bsmorgan bsmorgan May 19, 2014 at 16:47 UTC - 0 likes

    Please open a new ticket if this can be reproduced with the latest version.

  • Avatar of yossa yossa Nov 16, 2010 at 21:42 UTC - 0 likes

    I need to rethink how to implement it, because simple sorting is too slow and not acceptable.

    Last edited Nov 16, 2010 by yossa
  • Avatar of yossa yossa Nov 16, 2010 at 09:26 UTC - 0 likes

    BeanCounterUiFrame - it's the internal frame used both in external gui and auctions. I will commit a fix today after work. Sorting is also ready.

  • Avatar of RoloX2 RoloX2 Nov 15, 2010 at 19:59 UTC - 0 likes

    I see; I forgot about calling BeanCounter on its own; it works on that, without even shift-clicking, very nice.

    I disabled Auctionator to see if the BeanCounter tab would work as well but it didn't.

    Hazarding a speculative guess here, perhaps 'AuctionFrameTabUtilBeanCounter' is what you needed to know, based on this extract from Auc-Advanced\CoreUtil.lua:

    function lib.AddTab(tabButton, tabFrame)
    	-- Count the number of auction house tabs (including the tab we are going
    	-- to insert).
    	local tabCount = 1;
    	while (_G["AuctionFrameTab"..(tabCount)]) do
    		--check that tab has not already been created, since we can optionally remove tabs now
    		if _G["AuctionFrameTab"..(tabCount)]:GetName() == tabButton:GetName() then
    			lib.Print("Tab with that name already exists")
    			return
    		end
    		tabCount = tabCount + 1;
    	end
    
    	-- Find the correct location to insert our Search Auctions and Post Auctions
    	-- tabs. We want to insert them at the end or before BeanCounter's
    	-- Transactions tab.
    	local tabIndex = 1;
    	while (_G["AuctionFrameTab"..(tabIndex)] and
    		   _G["AuctionFrameTab"..(tabIndex)]:GetName() ~= "AuctionFrameTabUtilBeanCounter") do
    		tabIndex = tabIndex + 1;
    	end
    
    	-- Make room for the tab, if needed.
    	for index = tabCount, tabIndex + 1, -1  do
    		_G["AuctionFrameTab"..(index)] = _G["AuctionFrameTab"..(index - 1)];
    		_G["AuctionFrameTab"..(index)]:SetID(index);
    	end
    
    	-- Configure the frame.
    	tabFrame:SetParent("AuctionFrame");
    	tabFrame:SetPoint("TOPLEFT", "AuctionFrame", "TOPLEFT", 0, 0);
    	private.relevelFrame(tabFrame);
    
    	-- Configure the tab button.
    	_G["AuctionFrameTab"..tabIndex] = tabButton;
    	tabButton:SetParent("AuctionFrame");
    	tabButton:SetPoint("TOPLEFT", _G["AuctionFrameTab"..(tabIndex - 1)]:GetName(), "TOPRIGHT", -8, 0);
    	tabButton:SetID(tabIndex);
    	tabButton:Show();
    
    	-- If we inserted a tab in the middle, adjust the layout of the next tab button.
    	if (tabIndex < tabCount) then
    		local nextTabButton = _G["AuctionFrameTab"..(tabIndex + 1)];
    		nextTabButton:SetPoint("TOPLEFT", tabButton:GetName(), "TOPRIGHT", -8, 0);
    	end
    
    	-- Update the tab count.
    	PanelTemplates_SetNumTabs(AuctionFrame, tabCount)
    end
    
  • Avatar of yossa yossa Nov 15, 2010 at 09:46 UTC - 0 likes

    I tested it with a standalone bean counter - you can open it from SlideBar and you open bean counter in auction frame. I have to check what are the frame names when you do it like this. This search takes a few seconds that's why I want this functionality to work only when BeanCounter is visible.

    Last edited Nov 15, 2010 by yossa
  • Avatar of RoloX2 RoloX2 Nov 14, 2010 at 01:35 UTC - 0 likes

    haha sweet! I was going to ask for a shift-click into Beancounter. Unfortunately, It doesn't work for me. I have Auctioneer opened to the BeanCounter tab and I'm shift-clicking on the large icon in the recipe info window (or the reagent or the recipe in the list) but nothing gets sent to the Beancounter text box.

    I'm running Auctioneer Suite 5.10.4998, Auctionator 2.6.8, LSW 101beta, Skillet r226. I mention Auctionator since its tabs are last and Auctioneer/BeanCounter tries/believes BeanCounter is the last tab and it isn't.

    Save/load queue: thanks! (I was debating requesting multiple queue tabs but save/load is better).

  • Avatar of yossa yossa Nov 13, 2010 at 18:28 UTC - 0 likes

    sure,
    i already added some more support - configurable number of days and an option to search in bean counter if both addons are opened.
    I always thought that bean counter is not convenient, because you have to drag and drop or type the name of items. now you just click in skillet and bean counter is searching.

  • 7 comments

Facts

Last updated
May 19, 2014
Reported
Nov 13, 2010
Status
Declined - We decided not to take action on this ticket.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees