Skada Damage Meter

352 - No world boss segments

What steps will reproduce the problem?
Engage a world boss; Ordos, Celestials or any of the older ones.

What is the expected output? What do you see instead?
I expect Skada to create a boss segment.

What version of the product are you using?
latest alpha (r486 at time of posting)

Do you have an error log of what happened?
No lua error, this is a side-effect of LibBossIDs removal in r481 and later.

User When Change
oscarucb May 15, 2014 at 09:02 UTC Changed status from New to Fixed
Zarnivoop Feb 12, 2014 at 17:59 UTC Changed assigned to from Zarnivoop to funkydude

Changed priority from Medium to High
Dridzt Feb 06, 2014 at 10:29 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of oscarucb oscarucb May 04, 2014 at 11:14 UTC - 0 likes

    Fixed in r518, by rolling back r481

  • Avatar of Dridzt Dridzt Feb 16, 2014 at 17:32 UTC - 0 likes

    <<reply 2032438>>

    That is correct.
    I should have clarified in the ticket description this is in relation to the "only keep boss fights" option.

  • Avatar of oscarucb oscarucb Feb 16, 2014 at 17:11 UTC - 0 likes

    @funkydude: Go

    I assume the original poster is using the "Only keep boss fights" option to discard non-boss segments. So we still need to accurately determine what fights contain a boss (be it a world boss or heroic 5-man boss).

  • Avatar of funkydude funkydude Feb 16, 2014 at 16:11 UTC - 0 likes

    We have functionality for grabbing the first encountered mob and using it as the segment name (this is how trash works) and it doesn't place any form of bias on what the mob is. If anything, it should be more accurate on world bosses as there's only 1 mob. This is our "backup" for no engage events. I'll need to look into this.

  • Avatar of oscarucb oscarucb Feb 07, 2014 at 00:21 UTC - 0 likes

    I believe this was caused by r481:

    Shouldn't need LibBossIds any more. 5 man aren't really important enough to drag it along. Could add a UnitName("boss1") check if it really becomes an issue.

    The new ENCOUNTER_START event does not fire for any outdoor world bosses (and possibly other bosses as well). Nor does the "boss1" unit operate for these bosses or most 5-man bosses. IMO this commit should be rolled back.

    Last edited Feb 07, 2014 by oscarucb
  • Avatar of Dridzt Dridzt Feb 06, 2014 at 10:34 UTC - 0 likes

    This change has also made comparing test runs on the "boss" target dummies harder.
    You have to enable "keep all segments" if you want to do several passes to test a new trinket or a priority variation etc.

  • 6 comments

Facts

Last updated
May 15, 2014
Reported
Feb 06, 2014
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
High - Strongly want to resolve in the specified milestone.
Votes
2

Reported by

Possible assignees