317 - Auto Hide/Disable Hidden Problem (PVP)

"Hide in PvP" Option does not work,

Skada pops while in Battleground and collects data.

While skada active in battleground, unchecking/checking "Hide in PvP" option - Disables skada as intended.(You need to do that every other bg)

Version = r431

User	When	Change
Zarnivoop	Apr 01, 2013 at 09:34 UTC	Changed status from New to Fixed
Voidlyn	Feb 25, 2013 at 01:38 UTC	Changed name from Auto Hide/Disable Hidden Problem to Auto Hide/Disable Hidden Problem (PVP)
Voidlyn	Feb 25, 2013 at 01:38 UTC	Create

You must login to post a comment. Don't have an account? Register to get one!

2 comments

Barfolomeu Mar 31, 2013 at 20:41 UTC - 0 likes

I grew tired of waiting for this to be fixed, so I fixed it. Here's a patch that works when "hide in pvp" is set. Untested with all the permutations of display combinations:

diff -Nau Skada.lua.orig Skada.lua
--- Skada.lua.orig      2013-03-30 22:34:31.305542000 -0700
+++ Skada.lua   2013-03-31 00:07:39.639176400 -0700
@@ -849,7 +849,8 @@
                end

                -- Show window if we have enabled the "Hide when solo" option.
-               if Skada.db.profile.hidesolo then
+               -- But only when NOT in pvp and it's set to hide in pvp.
+               if Skada.db.profile.hidesolo and (Skada.db.profile.hidepvp and not is_in_pvp()) then
                        Skada:SetActive(true)
                end
        end

Last edited Mar 31, 2013 by Barfolomeu: More text.