Skada Damage Meter

256 - Error with absorved healing.

What steps will reproduce the problem?

1. Soloing daily quests, boomkin
2.
3.

What is the expected output? What do you see instead?

Expect no errors, but I got a series of errors while fighting a shaman mob.

What version of the product are you using?

r373

Do you have an error log of what happened?

10x Skada-r373\modules\SkadaHealing\Healing.lua:27 attempt to perform arithmetic on field "healingabsorbed" (a nil value)
Skada-r373\modules\SkadaHealing\Healing.lua:27 in function <Skada\modules\SkadaHealing\Healing.lua:10
Skada-r373\modules\SkadaHealing\Healing.lua:81 in function "func"
Skada\Skada-r373.lua:1402 in function <Skada\Skada.lua:1302
<string>:"safecall Dispatcher[19]":4: in function <string>:"safecall Dispatcher[19]":4
<in C code>
<string>:"safecall Dispatcher[19]":13: in function "?"
Ace3-r1045\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in function "Fire"
Ace3-r1045\AceEvent-3.0\AceEvent-3.0-3.lua:120 in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

Locals:
nil

Please provide any additional information below.

User When Change
Zarnivoop Feb 03, 2012 at 20:39 UTC
Curace Jan 18, 2012 at 18:51 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of Zarnivoop Zarnivoop Jan 20, 2012 at 08:55 UTC - 0 likes

    Right, when I add new attributes to existing modes I usually add them within their own "if this attribute does not exist, add it" section, so as not to break old saved sets.

  • Avatar of eridius eridius Jan 20, 2012 at 08:33 UTC - 0 likes

    Ok, the "real" fix is now in r375.

  • Avatar of eridius eridius Jan 20, 2012 at 08:22 UTC - 0 likes

    Zarnivoop, I did add it to the AddSetAttributes, the problem is that method only added the attributes to set.healing if set.healing didn't already exist. I committed r374, which changed log_heal() to not care if set.absorbedhealing existed, but it sounds like it'll be better to change AddSetAttributes() to always fix up set.healing instead.

  • Avatar of Zarnivoop Zarnivoop Jan 20, 2012 at 08:17 UTC - 0 likes

    Eridius, a set is a saved fight segment, the data storage structure used by all the built-in modes except Threat. Just make sure you add the new field to the set when Skada calls AddSetAttributes/AddPlayerAttributes. It is called both on saved sets upon login (to verify consistency) and new sets.

  • Avatar of eridius eridius Jan 20, 2012 at 06:07 UTC - 0 likes

    Alternatively, try updating to r374, which I just committed.

  • Avatar of eridius eridius Jan 20, 2012 at 06:05 UTC - 0 likes

    healingabsorbed is a field I added on Tuesday in r373. Somehow your set doesn't have that field. I admit I'm not entirely sure what a "set" is. Does the error go away if you reset Skada?

  • 6 comments

Facts

Last updated
Feb 03, 2012
Reported
Jan 18, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees