SexyMap

46 - Disable notification of player's own minimap ping

What is the enhancement in mind? How should it look and feel?
Option to not show notification of minimap ping for the player's own ping (as I usually know when I did it).

Please provide any additional information below.
Also, currently, when pings notification messages are are set to be output to the chat frame, quite often (if not always) when the player pings the minimap, the ping message is shown twice. Would be nice if it was only once.

User When Change
CaptWhyNot Aug 14, 2009 at 02:10 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of CaptWhyNot CaptWhyNot Dec 15, 2009 at 21:59 UTC - 0 likes

    This (along with a minor fix to duplicate ping detection) can be accomplished by modifying the MINIMAP_PING function in Ping.lua to the following [adds "if not UnitIsUnit(unit, "player") then" and changes an "and" to "or"]:

    -- MINIMAP_PING can fire twice at the same time, just a simple way of throttling it
    local lastX, lastY
    function mod:MINIMAP_PING(self, unit, x, y)
        if not UnitIsUnit(unit, "player") then
    	if( db.showPing and (lastX ~= x or lastY ~= y) ) then
    		lastX, lastY = x, y
    		
    		local color = RAID_CLASS_COLORS[select(2, UnitClass(unit))]
    		if db.showAt == "chat" then
    			DEFAULT_CHAT_FRAME:AddMessage(("Ping: |cFF%02x%02x%02x%s|r"):format(color.r * 255, color.g * 255, color.b * 255, UnitName(unit)))
    			pingFrame:Hide()
    		else
    			pingFrame.name:SetFormattedText("|cFF%02x%02x%02x%s|r", color.r * 255, color.g * 255, color.b * 255, UnitName(unit))
    --			pingFrame:SetWidth(pingFrame.name:GetStringWidth() + 14)
    --			pingFrame:SetHeight(pingFrame.name:GetStringHeight() + 10)
    			pingFrame:SetWidth(pingFrame.name:GetStringWidth() + 6)
    			pingFrame:SetHeight(pingFrame.name:GetStringHeight() + 4)
    			pingFrame:Show()
    		end
    	end
        end
    end
    
  • 1 comment

Facts

Reported
Aug 14, 2009
Status
New - Issue has not had initial review yet.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees