WowAce

doesnt show reputation gained by legion rep tokens

I've got the same error, and I noticed something weird about the rep frame - there's a blank entry just above Conjurer Margoss' line (fishing vendor NPC on a floating island near Dalaran).  It's not Rep2 doing something weird to make that happen either - it's still there without the mod enabled.  Different mod I've got that exposes various IDs isn't showing any information for it either.  Seems to be something on Blizzard's end - dug through my screenshots and I've got one from post-Legion release showing Rep2 working just fine, and found a thread on the WoW forums reporting the same issue (http://us.battle.net/forums/en/wow/topic/20748706238).

 

Fiddling around, will post if I figure out a patch job - this *seems* like it ought to be simple enough, but goodness knows that's bitten me in the rump before saying that...

 

*****

 

Edit - Well that was refreshingly as simple as I hoped it would be.  The "name" value (and presumably everything else, but I didn't bother checking) returned from GetFationInfo was nil, so I tossed in a basic nil check.  Change line 26 from

if (not isHeader or hasRep) then

to

if ((not isHeader or hasRep) and name) then

and *poof* everything seems to be behaving again.

Sadly, with the new reputations it seems that something has broken the addon. I'm getting the following error:

 

62x Rep2\Rep2-r48.lua:26: table index is nil
Rep2\Rep2-r48.lua:26: in function <Rep2\Rep2.lua:21>
Rep2\Rep2-r48.lua:44: in function <Rep2\Rep2.lua:35>
Rep2\Rep2-r48.lua:96: in function <Rep2\Rep2.lua:95>

Locals:
(for index) = 18
(for limit) = 20
(for step) = 1
i = 18
name = nil
_ = nil
standingID = 1
_ = 0
_ = 0
barValue = 0
_ = nil
_ = nil
isHeader = nil
_ = nil
hasRep = nil
(*temporary) = <table> {
 The Anglers = <table> {
 }
 The Scale of the Sands = <table> {
 }
 Nat Pagle = <table> {
 }
 Dreamweavers = <table> {
 }
 The Nightfallen = <table> {
 }
 Valarjar = <table> {
 }
 Highmountain Tribe = <table> {
 }
 The Wardens = <table> {
 }
 Court of Farondis = <table> {
 }
 Brood of Nozdormu = <table> {
 }
 The Tillers = <table> {
 }
}
(*temporary) = <table> {
}
(*temporary) = "table index is nil"
getfactioninfo = <function> defined =[C]:-1
factionVars = <table> {
 The Anglers = <table> {
 }
 The Scale of the Sands = <table> {
 }
 Nat Pagle = <table> {
 }
 Dreamweavers = <table> {
 }
 The Nightfallen = <table> {
 }
 Valarjar = <table> {
 }
 Highmountain Tribe = <table> {
 }
 The Wardens = <table> {
 }
 Court of Farondis = <table> {
 }
 Brood of Nozdormu = <table> {
 }
 The Tillers = <table> {
 }
}

As of today for 7.03 still use it and it works.

Are we going to get a Cata update? soon?

when i type /rep2 i get the standard blizz error. When i type /rep2 set5 i get the same error. Any ideas?

"Type '/help'for a listing of a few commands" is the error

Thanks to Dridzt on the wowace forums, it appears there is a fix that is working, so far.

Edit the Rep2.lua file. Change "MEETINGSTONE_CHANGED" to "PLAYER_ALIVE". This is done so that the faction information is available when it wants it. It was looking for faction information too soon.

Since this mod is deadish, I thought I would mention a replacement that is maintained.

WonderRep, http://wow.curse.com/downloads/wow-addons/details/wonder-rep-reputation.aspx

thanks for the suggestion - it works, to a degree, but it doesn't meet the standard set by rep2 - if anyone figures out a change we can make to our copies, or can point to a fixed version or direct replacement, please let us know

I know what is happening but I can't figure out how to fix it (I know nothing about writing mods - I just poked at it and tried it to see what happened). When Rep2 loads, it thinks there are zero factions. Therefore, it doesn't set up factionVars. Then, "if (not isHeader) and factionVars[name] then" always evaluates to false, because there is no factionVars, so the entire loop to check what faction changed is skipped. By toggling standby, the mod is made to rescan the factions so factionVars gets set and the work loop has something to gnaw on.

I can't figure out how to make it see the factions when it first loads. I thought the new 3.1 function, ExpandAllFactionHeaders, might help but it didn't seem to matter.

Ideas? Fixes?

If you toggle '/rep2 standby' off and then back on it seems to work again but you have to do it every time you log in.

Agreed, Fred7. Not seeing messages from spillover factions or "NNN more to go" messages.

Fubar - FactionsFu and Rep2 don't seem to play well together. If you have FactionsFu, disabling it should make Rep2 work again. If not, try downloading the newest Ace2 libraries
http://wow.curse.com/downloads/wow-addons/details/ace2.aspx
and replace the ones in the Rep2/Libs folder with the new ones.

I updated the libraries first which worked with a soft reload of the UI but once I exited and reentered the game it broke again and that's when I narrowed it down to FactionsFu. So it may or may not be necessary to update the libraries.

I dont use FactionsFu. I tried that ace library replacement and it seemed to work at first, then later Rep broke again.

This mod is dead unless someone pulls it out of the grave and repairs it.