RatingBuster

288 - Incorrect conversion on commas

Addon Version: r396
Wow Version: 5.2.0 (16733)
Locale: Chinese Simplified (zhCN)

What steps will reproduce the problem?
1. Viewing any items with stats more than 999.

What is the expected output? What do you see instead?
The output in game is as shown below:
+1,147力量(+147治疗, +0.17%招架)
It says 1147 strength only increase healing by 147 and parry by 0.17%, which should be the result of 147 strength.

A possible solution:
I inspected the locale file "zhCN.lua" in \RatingBuster\locales and found L["separators"] includes a ","(the English half-width comma) , which may mislead the addon to think +1,147 is two effects.
However, in my experience, Chinese version always uses ","(the full-width comma) as separators, and this comma is already in L["separators"].
I simply removed "," from that array, and found the display is correct now.
I am not sure if this will bring any side effects.

User When Change
lostcoaster Mar 21, 2013 at 17:45 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of cremor cremor Mar 22, 2013 at 19:46 UTC - 0 likes

    RatingBuster has an open repository. If you have a fix, please go ahead and check it in.

  • 1 comment

Facts

Reported
Mar 21, 2013
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees