RatingBuster

225 - Fix patch for druid errors

I see a lot of people reporting the same error, so i thought i would propose a fix for this issue.

Patch to fix druid errors in summary because of Feral Attack Power and old Predatory Strikes talent that no longer exists.

NOTE: There are still some leftover FAP defines in locale files i didn't bother removing.

--

@@ -233,7 +233,6 @@
     classDefaults.ratingSpell = true
     classDefaults.ratingPhysical = true
     classDefaults.sumMP = true
-    classDefaults.sumFAP = true
     classDefaults.sumHit = true
     classDefaults.sumCrit = true
     classDefaults.sumHaste = true
@@ -1280,14 +1279,6 @@
                             get = getProfileOption,
                             set = setProfileOptionAndClearCache,
                         },
-                        fap = {
-                            type = 'toggle',
-                            name = L["Sum Feral Attack Power"],
-                            desc = L["Feral Attack Power <- Feral Attack Power, Attack Power, Strength, Agility"],
-                            arg = "sumFAP",
-                            get = getProfileOption,
-                            set = setProfileOptionAndClearCache,
-                        },
                         hit = {
                             type = 'toggle',
                             name = L["Sum Hit Chance"],
@@ -2684,7 +2675,6 @@
     -- Mana - MANA, INT
     -- Attack Power - AP, STR, AGI
     -- Ranged Attack Power - RANGED_AP, INT, AP, STR, AGI
-    -- Feral Attack Power - FERAL_AP, AP, STR, AGI
     -- Spell Damage - SPELL_DMG, STA, INT, SPI
     -- Holy Damage - HOLY_SPELL_DMG, SPELL_DMG, INT, SPI
     -- Arcane Damage - ARCANE_SPELL_DMG, SPELL_DMG, INT
@@ -3417,28 +3407,6 @@
             return rap * (RatingBuster:GetStatMod("MOD_RANGED_AP") + RatingBuster:GetStatMod("MOD_AP") - 1)
         end,
     },
-    -- Feral Attack Power - FERAL_AP, AP, STR, AGI
-    {
-        option = "sumFAP",
-        name = "FERAL_AP",
-        func = function(sum, sumType, link)
-            -- Druid: Predatory Strikes 2,10: Increases 7%/14%/20% of any attack power on your equipped weapon.
-            local p = 0
-            if class == "DRUID" and select(5, GetTalentInfo(2, 10)) > 0 and weaponItemEquipLoc[select(9, GetItemInfo(link))] then
-                local r = select(5, GetTalentInfo(2, 10))
-                if r == 1 then
-                    p = 0.07
-                elseif r == 2 then
-                    p = 0.14
-                elseif r == 3 then
-                    p = 0.2
-                end
-            end
-            local mod = RatingBuster:GetStatMod("MOD_AP") + p
-            local fap = summaryFunc["AP"](sum, sumType, link) + (sum["FERAL_AP"] or 0) * mod
-            return fap
-        end,
-    },
     -- Hit Chance - MELEE_HIT_RATING
     {
         option = "sumHit",

--

User When Change
Ivora Sep 08, 2012 at 16:05 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of SLOKnightfall SLOKnightfall Sep 16, 2012 at 06:39 UTC - 0 likes

    @quatopl: Go

    The Feral Attack Power stat (FAP) was removed with Cata and was no longer needed. Druids just use the standard Attack Power from Agility now which show correctly in the tool tips when you are in bear/cat form.

    As for the Dodge issue, Blizzard changed the amount of dodge to = 1% so its going to be a while before I get a chance to figure out how to fix it.

  • Avatar of quatopl quatopl Sep 15, 2012 at 16:17 UTC - 0 likes

    well...i would say ty but with your fix patch we are loosing main stat comparison for DPS druids witch is AP (called FAP for droos). Because first time i didn't understand anything from your post (especially @@ -3417,28 +3407,6 @@ make me confused) so i started looking for fix by myself. And now i can say u've done too much job with removing FAP from RB lua.The only lines that have to be removed are: from 3427 up to 3436 that will remove RB error for droos but will not remove AP comparison witch btw work fine the only problem i have now is dodge formula...dodge is not counted properly. RB show me higher stat than i really getting from item.Because i'm lame in any programming I don't really know where to start looking for it. Any idea?

  • Avatar of SLOKnightfall SLOKnightfall Sep 15, 2012 at 00:39 UTC - 0 likes

    The un-needed druid code has been removed in the r366 build.

  • Avatar of Flaicher Flaicher Sep 11, 2012 at 16:17 UTC - 0 likes

    Thanks, this "patch" of yours fixed the errors ratingbuster was giving on my druid.

  • 4 comments

Facts

Reported
Sep 08, 2012
Status
New - Issue has not had initial review yet.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees