RatingBuster

172 - Bugout at 4.3 Reforge vendor

What steps will reproduce the problem?

1. Open one of the two "Arcane Reforgers" (tested locally at Alliance) with RatingBuster active.

What is the expected output? What do you see instead?

Expected: no issues.

Instead: error is thrown.

What version of the product are you using?

v1.6.5 with latest standalone (alpha/release) libraries.

Do you have an error log of what happened?

["message"] = "Interface\\FrameXML\\UIDropDownMenu.lua:62: attempt to index local 'frame' (a nil value):\nRatingBuster-1.6.4 (r346)\\RatingBuster.lua:2436: in function `?'\nCallbackHandler-1.0-6:147: in function <...onLoader\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:147>\n<string>:\"safecall Dispatcher[2]\":4: in function <[string \"safecall Dispatcher[2]\"]:4>\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":13: in function `?'\nCallbackHandler-1.0-6:92: in function `Fire'\nAceEvent-3.0-3 (Ace3):120: in function <Interface\\AddOns\\Ace3\\AceEvent-3.0\\AceEvent-3.0.lua:119>\n<in C code>: in function `LoadAddOn'\nInterface\\FrameXML\\UIParent.lua:274: in function `UIParentLoadAddOn':\nInterface\\FrameXML\\UIParent.lua:364: in function `Reforging_LoadUI':\nInterface\\FrameXML\\UIParent.lua:1118: in function <Interface\\FrameXML\\UIParent.lua:582>:\n<in C code>: in function `TurnOrActionStop'\n<string>:\"TURNORACTION\":4: in function <[string \"TURNORACTION\"]:1>\n",
			["type"] = "error",
			["session"] = 5038,
			["counter"] = 1,
		}, -- [999]

Please provide any additional information below.

100% repeatable when opening that vendor.

User When Change
Zidomo Dec 09, 2011 at 22:07 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Myth024 Myth024 Feb 13, 2012 at 19:57 UTC - 0 likes

    The error is being thrown because the old Reforge used drop down menu's and the new one uses radio buttons. The basic interface has changed. I've found that most times with RB enabled I will get a blank space on the left with only a single item to be reforged and it becomes un-clickable. Sometimes a simple UI reload will fix the issue. Just an observation that I hope helps. Here is also an error log thats a bit more verbose than I've seen that may help as well.

    Date: 2012-02-13 15:03:42
    ID: 1
    Error occured in: Global
    Count: 1
    Message: ..\FrameXML\UIDropDownMenu.lua line 62:
       attempt to index local 'frame' (a nil value)
    Debug:
       (tail call): ?
       ..\FrameXML\UIDropDownMenu.lua:62 UIDropDownMenu_Initialize()
       RatingBuster\RatingBuster.lua:2436 ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
          ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
       [string "safecall Dispatcher[2]"]:4:
          [string "safecall Dispatcher[2]"]:4
       [C]: ?
       [string "safecall Dispatcher[2]"]:13: ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92 Fire()
       Ace3\AceEvent-3.0\AceEvent-3.0.lua:120
          Ace3\AceEvent-3.0\AceEvent-3.0.lua:119
       [C]: LoadAddOn()
       ..\FrameXML\UIParent.lua:274 UIParentLoadAddOn()
       ..\FrameXML\UIParent.lua:364 Reforging_LoadUI()
       ..\FrameXML\UIParent.lua:1118
          ..\FrameXML\UIParent.lua:582
       [C]: TurnOrActionStop()
       [string "TURNORACTION"]:4:
          [string "TURNORACTION"]:1
    AddOns:
      Swatter, v5.13.5258 (BoldBandicoot)
      Ace3, v
      ACP, v3.3.17
      RatingBuster, v
      BlizRuntimeLib_enUS v4.3.2.40300 <us>
      (ck=7a)

    Last edited Feb 13, 2012 by Myth024: Include error info
  • Avatar of LightsfuryUther LightsfuryUther Jan 10, 2012 at 00:20 UTC - 0 likes

    This problem should be fixed with revision 349.

    @mattnessx: Go

    I went ahead and added your patch to my working copy. I'm going to test it for a bit before I commit it to the repo.

  • Avatar of mattnessx mattnessx Jan 07, 2012 at 20:41 UTC - 0 likes

    I'm attaching a patch that will disable the integration with the reforge UI and stop the LUA errors, until they can be properly addressed.

    Index: RatingBuster.lua
    ===================================================================
    --- RatingBuster.lua	(revision 349)
    +++ RatingBuster.lua	(working copy)
    @@ -538,6 +538,16 @@
     					get = getProfileOption,
     					set = setProfileOptionAndClearCache,
     				},
    +				enable_reforge_ui = {
    +					type = 'toggle',
    +					order = 5,
    +					width = "double",
    +					name = L["Enable on Blizzard Reforging UI"],
    +					desc = L["Disabling will prevent LUA errors until the reforging functionality can be fixed."],
    +					arg = "enableReforgeUi",
    +					get = getProfileOption,
    +					set = setProfileOptionAndClearCache,
    +				},
     				usereqlv = {
     					type = 'toggle',
     					order = 7,
    @@ -2333,6 +2343,7 @@
     -- Reforging UI --
     ------------------
     function RatingBuster:ADDON_LOADED(event, name)
    +	if not profileDB.enableReforgeUi then return end
     	if name ~= "Blizzard_ReforgingUI" then return end
     	--print("Blizzard_ReforgingUI Loaded")
       local reforgeToRating = {
    Index: RatingBuster-Locale-enUS.lua
    ===================================================================
    --- RatingBuster-Locale-enUS.lua	(revision 349)
    +++ RatingBuster-Locale-enUS.lua	(working copy)
    @@ -41,6 +41,9 @@
     -- /rb subtract_equip
     L["Enable Subtract Equipped Stats"] = true
     L["Enable for more accurate calculation of Mana Regen from Intellect and Spirit, and diminishing stats like Dodge, Parry, Resilience"] = true
    +-- /rb enable_reforge_ui
    +L["Enable on Blizzard Reforging UI"] = true
    +L["Disabling will prevent LUA errors until the reforging functionality can be fixed."] = true
     -- /rb usereqlv
     L["Use Required Level"] = true
     L["Calculate using the required level if you are below the required level"] = true
    
    Name Description Size MD5
    DisableReforgeUI.patch Patch to disable reforging ui ... 1.7 KiB ecf46208f60c...
  • Avatar of sp00n sp00n Jan 03, 2012 at 12:34 UTC - 0 likes

    Yeah, seeing that happen as well. Additionally the 1.6.5 / r348 version still registers as 1.6.4 and r346 internally.

    I've commented out line 2436 and 2437 in RatingBuster.lua, and the error has gone away without affecting any other functionality - at least I hope so, the problem is only with the reforging window anyway, which now uses radio buttons instead of a drop down list.

  • Avatar of Gabriel Gabriel Dec 29, 2011 at 13:55 UTC - 0 likes

    can confirm this bug

  • 5 comments

Facts

Last updated
Mar 30, 2012
Reported
Dec 09, 2011
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
11

Reported by

Possible assignees