182 - Drum buffs and fort inscription
What is the enhancement in mind? How should it look and feel?
Is it possible, when a buff is not able to be provided because the class is missing, that there be a warning for leatherworkers with the appropriate drums? This includes the kings drums and MotW drums. Along these lines, also for the inscription scrolls to provide fortitude.
Please provide any additional information below.
| User | When | Change |
|---|---|---|
| danielbarron | Sun, 15 Nov 2009 22:21:22 | Changed status from Started to Fixed |
| danielbarron | Sun, 18 Oct 2009 21:41:05 | Changed status from Replied to Started |
| cremor | Sun, 18 Oct 2009 14:29:15 | Changed status from Waiting to Replied |
| danielbarron | Sat, 17 Oct 2009 18:05:24 | Changed status from Replied to Waiting |
| cremor | Sun, 11 Oct 2009 08:42:28 | Changed status from Waiting to Replied |
| danielbarron | Sat, 10 Oct 2009 22:25:50 | Changed status from Replied to Waiting |
| danielbarron | Sat, 10 Oct 2009 09:57:50 | Changed status from Waiting to Replied |
| danielbarron | Sat, 10 Oct 2009 09:56:52 | Changed status from Declined to Waiting |
| danielbarron | Wed, 07 Oct 2009 22:45:03 | Changed status from New to Declined |
| Kleo | Wed, 07 Oct 2009 06:16:29 | Create |
Facts
- Last updated on
- 15 Nov 2009
- Reported on
- 07 Oct 2009
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
- #11
danielbarron Sun, 15 Nov 2009 22:20:55Added in r311
- #10
danielbarron Tue, 20 Oct 2009 23:10:38r305 has king support for when no pally now.
Still need to do the with-pally support.
- #9
danielbarron Mon, 19 Oct 2009 23:47:49Indeed no profession needed. I have implemented everything so far except how to handle less than max pallies plus fake kings. When I am not spending the evening raiding I will get on to it.
- #8
Pericles Mon, 19 Oct 2009 10:55:13Forgive me I've never ever played a pally I had assumed that the Blessing of Sanctuary was available to any pally I now realise its a Prot pally only talent.
I stand by my statement if the group makeup had a Prot Pally rather than a holy pally as then you can get BoS + BOW (shammy) & BoM (Warrior) + Fake Kings, which is surely better than just BoK on its own especially when BoS gives 10% Str & 10% Stamina, boosting 2 of the 5 stats that fake kings gives by 2% further, as well of course as a 3% damage reduction across the raid.
- #7
cremor Sun, 18 Oct 2009 14:29:14@Pericles
First, as Kleo already said, you don't need the profession to use the items.
Second, don't say that we SHOULD use Drums of Forgotten Kings if only one Paladin is in the raid. Let's assume that we have a Holy Paladin, a Restoration Shaman and a Warrior with talented shout in the raid. BoW is provided by Shaman, BoM by Warrior, so why use a 8% Drum over a 10% BoK?
It is better if you are missing the other buffs otherwise, but it is for sure not needed every time there is only one Paladin.
- #6
danielbarron Sat, 17 Oct 2009 18:05:07Try r303. The kings support is not quite there yet but it is partially and the other two are there.
- #5
Kleo Fri, 16 Oct 2009 20:57:31Actually, it turns out that one doesn't have to be a leatherworker to use the drums for the kings and paw buffs. Anyone can use these drums, (similar to anyone being able to use the fort inscription) so a check on professions would not be needed.
It could probably be more along the lines where people set in options whether drums and the fort inscription are available.
- #4
Pericles Thu, 15 Oct 2009 16:42:00This would be a very good addition, and should be relatively easy to add, but requires a check on an available profession in the raid :( still this can be fetched via
local numSkills = GetNumTradeSkills()
local skillName, skillType, numAvailable, isExpanded, altVerb = GetTradeSkillInfo(skillIndex)
and querying
local tradeskillName, currentLevel, maxLevel = GetTradeSkillLine();
where skillType = "header"
Tests...
No Priests = Check for inscription and show Fake Fortitude if available.
No Druid = Check for leatherworker and show Fake MotW if available
Paladins slightly different if you have only 1 paladin then you SHOULD be buffing BoW/BoM or BoS and NOT BoK as you can use Fake Kings (aka Drums of Forgotten Kings). So pally test is dependent on number of pallys if all pallys have all pally buffs covered you don't need to worry about Fake Kings if there isn't a full set of pallys then best to get extra pally buff AND fake kings.
So for Pallys its if not max pallys then check for leatherworker and show Fake Kings if available.
As an addon author myself I'd be happy to assist with this if you need assistance. Currently I've heard raid leaders say RBS is "broken" because it warns about missing BoK when we have used drums.
Personally I'd add extra 3 extra icons for the 3 fakes, and activate or deactivate them as required depending on numbers of priest/pally/druids.
- #3
cremor Sun, 11 Oct 2009 08:42:27I think we have two possibilities:
1. If no Priest/Paladin/Druid is in the raid, check for the drum/scroll buffs on the same icon that is usually used for the class buffs.
2. If no Priest/Paladin/Druid is in the raid, still disable their buff checks but enable new ones for the drums/scrolls.
- #2
danielbarron Sat, 10 Oct 2009 09:57:49I have now seen this in action. The drums. I think I was too hasty so can you explain what and how it should check?