QuestAgent

14 - Update patch for

What does the provided patch do?

  • Copies Mop Compatibility layer from QuestAgent.lua to QuestFrame.lua (fixes 1 of 2 problems with quest sharing)
  • Copies commPrefix from QuestAgent.lua to QuestFrame.lua (fixes the other problem with quest sharing)
  • Adds better support for cross-realm players. (fixes some display issues in the tooltip)
  • Updates TOC for 5.2

Please provide any additional information below.

Sadly cross-realm whispers are not easily possible as it is a limitation of the WoW API provided by Blizzard. SendAddonMessage will silently fail to send messages to players on other realms even if you are RealID friends with each other or they are in your party/raid. QuestAgent uses the AceComm-3.0 library as a very nice wrapper around SendAddonMessage.

There are two ways around this limitation. One being to rewrite the portions of the addon that relies on whispers to instead use party chat. This may require rewriting other portions of the addon as well to cut down the amount of unneeded messages caused by moving from a mix of broadcast and personal whispers to all broadcast.

The other way is to write a wrapper that detects if the destination whisper is to a cross-realm player or not. If they are not a cross-realm player proceed the same as always. If they are a cross-realm player then use SendChatMessage() to send the whisper as it is capable of send cross-realm messages when you are RealID or in the same party/raid with the receiver. That however opens up another bag of worms with both sending and receiving the messages. On the sending side I have to follow strict rules: max length 255 characters and not all characters are allowed. On the receiving side I have to register an eventfilter for whispers and hide them whenever a whisper comes from QuestAgent.

Honestly both ways would not be fun at all and a real pain. It would probably be easiest to get Blizzard to update SendAddonMessage to work as expected. I say if SendChatMessage("AQGNT-Hello Bob!", "WHISPER", "Common", "Bob-Archimonde") would succeed then SendAddonMessage("QAGNT", "Hello Bob!", "WHISPER", "Bob-Archimonde") should too!

Name Size MD5
QuestAgent-5.2.patch 6.1 KiB 659572132012...
User When Change
credomane Mar 30, 2013 at 23:27 UTC

Added attachment QuestAgent-5.2.patch

credomane Mar 30, 2013 at 23:27 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Allara Allara Aug 02, 2013 at 16:11 UTC - 0 likes

    @Azareus: Go

    Actually I'm not really sure how to apply the patch either. I've never done it with TortoiseSVN, didn't even know it had that ability.

  • Avatar of Azareus Azareus Aug 02, 2013 at 11:02 UTC - 0 likes

    Is there a way to apply this patch without waiting for an addon update?

    I really need this addon (it doesnt work that well with latest game version) but if I try to use TortoiseSVN to apply the .patch file I get "rejected patch hunks" for all of the files...

    Help!

  • Avatar of credomane credomane Mar 31, 2013 at 03:43 UTC - 0 likes

    I have no desire to write my own comm solution either. Though I'd make sure there wasn't any whispers sent to players without the addon. I could still use sendaddonmessage through party to locate those that had the addon and only send them the special whispers. I did think about making a custom comm for about 2 hours and said no way, not happening, stop thinking about it.

    No worries. Enjoy your weekend!

  • Avatar of Allara Allara Mar 30, 2013 at 23:35 UTC - 0 likes

    Anyway, good stuff. I'm away for the weekend so I'll have to take a look at this next week. Thanks!

  • Avatar of Allara Allara Mar 30, 2013 at 23:35 UTC - 0 likes

    Yeah I'm not interested in writing/maintaining my own comm solution, that takes us back to the dark ages in 2005 before SendAddonMessage existed. The giants of the day (i.e. Cosmos) went through major pains including stuff like realm-wide chat channels, whispers, guild and raid chat, all to facilitate communication between addons. It's extremely difficult to do right and would severely impact players who don't have QuestAgent installed (those players would see the addon traffic because they wouldn't have any way to filter it out).

  • 5 comments

Facts

Last updated
Mar 30, 2013
Reported
Mar 30, 2013
Status
New - Issue has not had initial review yet.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees