Prat 3.0

645 - Smart Group (/gr) does not work (ongoing MoP issue)

What steps will reproduce the problem?
1. Have channel sticky/smart group module enabled
2. Attempt to chat

What is the expected output? What do you see instead?
Prat throws an error when trying to chat, and of course sticky doesn't work.

What version of the product are you using?
3.5.0, 3.5.1, 3.5.2

*IMPORTANT* -> Can you reproduce the problem when ONLY Prat is running?
Yes

Do you play on US or EU. What language do you use?
enUS

What is the exact problem and how can you fix it?
ChannelSticky.lua lines 478 and 480 should be changed as follows:

478 elseif GetNumRaidMembers() > 0 then

changed to

478 elseif IsInRaid() then

480 elseif GetNumPartyMembers() > 0 then

changed to

480 elseif IsInGroup() then

I reported this issue quite a long time ago in the comments on your Curse page, but it's apparent you take submitting tickets seriously or just don't read the comments. Nothing wrong with that, but I just happen to get around to reporting this issue along with the new 5.1 issue.

User When Change
Kanegasi Nov 27, 2012 at 23:57 UTC Changed description:
  What steps will reproduce the problem?
- 1. Have channel sticky module enabled
+ 1. Have channel sticky/smart group module enabled
  2. Attempt to chat
  What is the expected output? What do you see instead?
Kanegasi Nov 27, 2012 at 23:57 UTC Changed name from Channel Sticky does not work (ongoing MoP issue) to Smart Group (/gr) does not work (ongoing MoP issue)
Kanegasi Nov 27, 2012 at 23:52 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Kanegasi Kanegasi Mar 09, 2013 at 02:22 UTC - 0 likes

    @Gregory: Go

    The code for Smart Group was commented out for another reason, but I forgot what the changelog said when it happened. Instance chat is not a replacement. That chat type is only used in LFR, LFD, and Scenarios. Instance chat is not active during a raid or manual dungeon (physically going to the dungeon). Not only that, but Smart Group encompasses every possible chat, defaulting to /say when none of the others are in use. There is also no Instance chat when raiding a world boss.

    The Smart Group key is/was extremely useful and so far, I've just been uncommenting the code back out and doing the change I have mentioned in this ticket. Smart Group still works flawlessly for me.

  • Avatar of Gregory Gregory Feb 12, 2013 at 18:37 UTC - 0 likes

    /gr command got removed at some point because same builtin command was added in mop. why remove it ? could just rename. also need to fix smart group keybinding (f.e. just make it open /instance_chat).

  • Avatar of Kanegasi Kanegasi Nov 27, 2012 at 23:57 UTC - 0 likes

    oops

  • Avatar of Kanegasi Kanegasi Nov 27, 2012 at 23:53 UTC - 0 likes

    Something to add, I have been using the code changes I suggested above since I found the problem. When updating to 3.5.1, and again today to 3.5.2, the code reverted and the error occurred again.

  • 4 comments

Facts

Last updated
Feb 12, 2013
Reported
Nov 27, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1
Component
Specific Module

Reported by

Possible assignees