Prat 3.0

601 - PlayerNames RealId Fix.

line 1347 old:
local _, givenName, surname, _, toon, id = BNGetFriendInfo(i)
new:
local id, givenName, surname = BNGetFriendInfo(i)

line 1350 old:
if BNTokenCombineGivenAndSurname(givenName .. surname) == message.PLAYER then
new:
if BNTokenFindName(givenName .. surname) == message.PLAYER then

User When Change
Egris Sep 04, 2012 at 01:07 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of watchout watchout Sep 11, 2012 at 02:42 UTC - 0 likes

    @Ralin: Go

    I posted the content of a ".diff" file, it's generated by a tool, and can be applied by one. The line numbers are correct. They start at the additionally displayed lines (the ones in black font coloring)

    As a human, I'd suggest simply going to the indicated line number, look for the lines that match the red ones and replace them with the green ones

  • Avatar of Ralin Ralin Sep 10, 2012 at 23:07 UTC - 0 likes

    Worked for me. The only thing i'd say to watch out for is that the listed entries for what the "old" line is supposed to say if that's what you're going by instead of line number may actually differ (it did for me). In hindsight, I probably should have copied what my old line values were to post it up in case they were helpful to anyone.

  • Avatar of Talyrius Talyrius Sep 09, 2012 at 18:44 UTC - 0 likes

    @skyesfury: Go

    In that case, you did something wrong.

  • Avatar of skyesfury skyesfury Sep 08, 2012 at 21:40 UTC - 0 likes

    @watchout: Go

    Watchout, your code didn't work for me. It caused error upon log in instead of when I send a whisper to someone.

  • Avatar of maddhawk maddhawk Sep 08, 2012 at 19:32 UTC - 0 likes

    @watchout: Go

    This fix worked perfectly. If anyone needs a good editor with line numbers to apply this fix, check out Notepad. It is open source and free on the web and is an amazing programming tool.

  • Avatar of watchout watchout Sep 07, 2012 at 14:28 UTC - 0 likes

    I don't think the original solution in this report actually works, since BNGetFriendInfo has new return values

    Use this instead:

    --- C:/World of Warcraft/Interface/AddOns/Prat-3.0/modules/PlayerNames - Original.lua	Di Sep  4 19:41:53 2012
    +++ C:/World of Warcraft/Interface/AddOns/Prat-3.0/modules/PlayerNames.lua	Fr Sep  7 16:10:41 2012
    @@ -1344,10 +1344,10 @@
           if self.db.profile.realidcolor == "CLASS" then
             local numFriends = BNGetNumFriends()
             for i = 1, numFriends do
    -          local _, givenName, surname, toon, id = BNGetFriendInfo(i)
    +          local _, combinedName, battletag, unknown, toon, id = BNGetFriendInfo(i)
     
               if id then
    -            if BNTokenCombineGivenAndSurname(givenName .. surname) == message.PLAYER then
    +            if combinedName == message.PLAYER then
     
                   local _, toonName, client, realmName, _, faction, race, class, _, zoneName, level, gameText,
                     broadcastText, broadcastTime = BNGetToonInfo(id)
    

    at least with this my bn friends are colored by their toon class

    Last edited Sep 08, 2012 by watchout
  • 6 comments

Facts

Last updated
Sep 20, 2012
Reported
Sep 04, 2012
Status
New - Issue has not had initial review yet.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
3
Component
Specific Module

Reported by

Possible assignees