Prat 3.0

572 - CustomFilters ignore NPC yell filters if EventNames module is disabled

What steps will reproduce the problem?
1. Create a custom filter for Inbound for a "Creature Yell". For example "The zeppelin to", then hang out near the Orgrimmar flight master.
2. Unload/disable "EventNames" module.
3. OR Uncheck "Process all events" under EventNames.

What is the expected output? What do you see instead?
The creature yells are not filtered and pass through ignored.
If you whisper yourself a matching string with "Incoming Whispers" checked on the filter, it will catch it fine.

What version of the product are you using?
3.0 - 11-29-2011

*IMPORTANT* -> Can you reproduce the problem when ONLY Prat is running?
Yes. With all 3 Prat boxes checked on the Addons panel and no other addons loaded, the problem persists.

Do you play on US or EU. What language do you use?
US English

Do you have an error log of what happened?
Whispering myself VS the creature yell, the filter is set to replace the text with "ballsballsballs" to test. (If it worked, I would have it just block it)

[04:38:44] Greeb Ramrocket yells: The zeppelin to Warsong Hold has just arrived! All aboard for Borean Tundra!
[04:38:51] [W <] [85:Kaustos]: ffffffballsballsballsffffffff
[04:38:51] [W ->] [85:Kaustos]: ffffffThe zeppelin toffffffff

Please provide any additional information below.

edit: I've found that doing    Prat.EnableProcessingForEvent("CHAT_MSG_MONSTER_YELL")    allows the CustomFilters module to catch npc yells without needing to rely on EventNames to enable all the events and all the verbose printing it does.

User When Change
kaustos Dec 31, 2011 at 20:10 UTC Changed description:
  [04:38:51] [W ->] [85:Kaustos]: ffffffThe zeppelin toffffffff

  Please provide any additional information below.
+
+ edit: I've found that doing    Prat.EnableProcessingForEvent("CHAT_MSG_MONSTER_YELL")    allows the CustomFilters module to catch npc yells without needing to rely on EventNames to enable all the events and all the verbose printing it does.
- When EventNames is enabled, Prat began parsing emotes which I didn't realize it ignored before. Makes them a little unnatural to read, ie:
- [04:41:48] [85:Kaustos]You wave.
- Instead of just "You wave", and when other players do emotes it looks more like they're talking in raid or bg chat since the colors are almost the same.
- I assume the EventNames module is mostly for debugging and isn't expected to always be loaded.
kaustos Dec 20, 2011 at 22:50 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Dec 31, 2011
Reported
Dec 20, 2011
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees