PitBull Unit Frames 4.0

1048 - [PATCH] Only enable ComboPoints when appropriate

ComboPoints is loaded for all toons. This wasn't really a problem before (aside from unnecessary resource usage during addon loading), but with the background enabled, this is now a problem.

The attached patch does 3 things:

  1. Adds a X-PitBull4-Condition to ComboPoints to only load for rogues and druids
  2. Adds a check at the top of the module to only continue if you're a rogue or a druid (primarily useful for debug installations)
  3. If you're a druid, it modifies UpdateFrame to only set up the frame if you're in cat form
Name Size MD5
combopoints.patch 2.4 KiB 1503c19dd45b...
User When Change
Shefki Aug 03, 2013 at 04:55 UTC
eridius Aug 03, 2013 at 03:55 UTC

Added attachment combopoints.patch

eridius Aug 03, 2013 at 03:55 UTC

Deleted attachment combopoints.patch: Obsolete

eridius Jul 26, 2013 at 06:06 UTC

Added attachment combopoints.patch

eridius Jul 26, 2013 at 06:06 UTC

Deleted attachment combopoints.patch: Replacing with a new one

eridius Jul 26, 2013 at 05:44 UTC

Added attachment combopoints.patch

eridius Jul 26, 2013 at 05:44 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of Shefki Shefki Aug 03, 2013 at 04:58 UTC - 0 likes

    Applied the latest patch. Not ideal but it's good enough.

  • Avatar of eridius eridius Aug 03, 2013 at 03:56 UTC - 0 likes

    Patch updated to behave as described in my comment.

  • Avatar of eridius eridius Aug 03, 2013 at 03:42 UTC - 0 likes

    Hrm, ok. So the module has to always load, and the short-circuit at the top has to be removed. But I still want to hide the background under normal circumstances on a non-combopoint-enabled class. So maybe it allows UpdateFrame to continue if you're in a vehicle and you have combo points? (so that way you don't unexpectedly get the combo point display when entering any of the numerous vehicles that don't have combo points).

  • Avatar of Shefki Shefki Aug 03, 2013 at 00:35 UTC - 0 likes

    Yup Stanzilla is right. We used to have just such a limitation in PB3 and we removed it for Malygos.

  • Avatar of Stanzilla Stanzilla Aug 02, 2013 at 22:41 UTC - 0 likes

    What about situations like Malygos where Vehicles use Combo Points?

  • Avatar of eridius eridius Jul 26, 2013 at 05:45 UTC - 0 likes

    Attached patch is in mbox format (generated with git format-patch). If you're unfamiliar with this format, you can apply with

    git am combopoints.patch
    

    This will create the full commit, with authorship info and commit message.

  • 6 comments

Facts

Last updated
Aug 03, 2013
Reported
Jul 26, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees