PitBull Unit Frames 4.0

1047 - Boss and arena frames

Adds boss and arena units to unit groups

http://pastebin.com/n9e4c7LN

User When Change
Stanzilla Nov 04, 2013 at 12:49 UTC Changed status from New to Fixed
nebula169 Jul 16, 2013 at 20:08 UTC Changed description:
  Adds boss and arena units to unit groups

- http://www.wowace.com/paste/tans879g36yx1f0e/
+ http://pastebin.com/n9e4c7LN
nebula169 Jul 16, 2013 at 19:46 UTC Changed description:
  Adds boss and arena units to unit groups

- Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)
-
- http://www.wowace.com/paste/8117/
+ http://www.wowace.com/paste/tans879g36yx1f0e/
Stanzilla Jul 10, 2013 at 19:26 UTC Changed assigned to from ckknight to Shefki
nebula169 Jul 10, 2013 at 06:06 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://www.wowace.com/paste/8116/
+ http://www.wowace.com/paste/8117/
nebula169 Jul 10, 2013 at 05:12 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://paste2.org/6KhpVCD1
+ http://www.wowace.com/paste/8116/
nebula169 Jul 10, 2013 at 03:55 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://paste2.org/P822x8Db
+ http://paste2.org/6KhpVCD1
nebula169 Jul 10, 2013 at 03:33 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://paste2.org/6N5EGzm3
+ http://paste2.org/P822x8Db
nebula169 Jul 10, 2013 at 03:06 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://paste2.org/eJ4Jc6ks
+ http://paste2.org/6N5EGzm3
nebula169 Jul 09, 2013 at 19:49 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- http://paste2.org/EBNO6nhX
+ http://paste2.org/eJ4Jc6ks
nebula169 Jul 09, 2013 at 18:01 UTC Changed description:
- Adds boss and arena unit groups
+ Adds boss and arena units to unit groups
-
- Edit: Changed :RefreshGroup() to :UpdateMembers(), dur.
-
- Also sometimes when you create a new group, the layout doesn't get applied until you relog or switch profiles. Happened a few times randomly, but not when I was trying to debug it, so not sure if I was missing initializing something before calling :RefreshLayout() or what.
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)
+ http://paste2.org/EBNO6nhX
- diff: http://pastebin.com/DzqP6CED
- git patch: http://pastebin.com/bJyangit
nebula169 Jul 09, 2013 at 16:50 UTC Changed description:
  Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- patch: http://pastebin.com/DzqP6CED (diffed against head now! >.>)
+ diff: http://pastebin.com/DzqP6CED
+ git patch: http://pastebin.com/bJyangit
nebula169 Jul 09, 2013 at 16:16 UTC Changed description:
  Adds boss and arena unit groups

- I think the only issue I have left is forcing a refresh on the frame for texts, is that possible? Didn't look like :RefreshGroup was doing it. Seems better than adding INSTANCE_ENCOUNT_ENGAGE_UNIT/ARENA_OPPONENT_UPDATE to all the texts
+ Edit: Changed :RefreshGroup() to :UpdateMembers(), dur.

  Also sometimes when you create a new group, the layout doesn't get applied until you relog or switch profiles. Happened a few times randomly, but not when I was trying to debug it, so not sure if I was missing initializing something before calling :RefreshLayout() or what.
- using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)
+ Using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)
  patch: http://pastebin.com/DzqP6CED (diffed against head now! >.>)
nebula169 Jul 09, 2013 at 16:10 UTC Changed description:
  using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- patch: http://pastebin.com/e4RC9AVg (diffed against head now! >.>)
+ patch: http://pastebin.com/DzqP6CED (diffed against head now! >.>)
nebula169 Jul 09, 2013 at 07:27 UTC Changed description:
  using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- patch: http://pastebin.com/MVdSigAJ (diffed against head now! >.>)
+ patch: http://pastebin.com/e4RC9AVg (diffed against head now! >.>)
nebula169 Jul 09, 2013 at 06:53 UTC Changed description:
  Adds boss and arena unit groups

+ I think the only issue I have left is forcing a refresh on the frame for texts, is that possible? Didn't look like :RefreshGroup was doing it. Seems better than adding INSTANCE_ENCOUNT_ENGAGE_UNIT/ARENA_OPPONENT_UPDATE to all the texts
+
- I think the only issue I have left is sometimes when you create a new group, the layout doesn't get applied until you relog or switch profiles. Happened a few times randomly, but not when I was trying to debug it, so not sure if I was missing initializing something before calling :RefreshLayout() or what.
+ Also sometimes when you create a new group, the layout doesn't get applied until you relog or switch profiles. Happened a few times randomly, but not when I was trying to debug it, so not sure if I was missing initializing something before calling :RefreshLayout() or what.
  using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)
- patch: http://pastebin.com/MVdSigAJ (updated against head)
+ patch: http://pastebin.com/MVdSigAJ (diffed against head now! >.>)
nebula169 Jul 09, 2013 at 06:27 UTC Changed description:
  Adds boss and arena unit groups
-
- My local copy was a bit more different than the head than I expected, so there are some instances of code blocks moving around. Other than ripping out compat code, updating the unit dropdrown menu, and fixing a few typos, the underlying code for singletons and SecureGroupHeader frames shouldn't have changed. I didn't feel like cherry picking my changes into a clean wc, but this will atleast give you something to review :p

  I think the only issue I have left is sometimes when you create a new group, the layout doesn't get applied until you relog or switch profiles. Happened a few times randomly, but not when I was trying to debug it, so not sure if I was missing initializing something before calling :RefreshLayout() or what.
  using arena units and the hide blizzard stuff is pretty untested. (re: dry coded)

- patch: http://pastebin.com/KeGhzaid
+ patch: http://pastebin.com/MVdSigAJ (updated against head)
nebula169 Jul 09, 2013 at 01:07 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Nov 04, 2013
Reported
Jul 09, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees