16 - In Raids, Parrot eats tons of CPU due to Ferocious Inspiration/Unleashed Rage spam

What steps will reproduce the problem?
1. Create a raid, fill it with people, watch in horror as you are spammed by quickly refreshing abilities.

What version of the product are you using?
1.6.1-beta1

This shouldn't be happening and I think it's because SPELL_AURA_REFRESH isn't being handled at all by Parrot. Even using the suppression stuff, it still eats a lot of CPU and kills your framerate because it's processing it invisibly.

User	When	Change
profalbert	Wed, 19 Aug 2009 20:59:11	Changed status from Started to Fixed
profalbert	Tue, 17 Feb 2009 23:51:56	Changed status from Accepted to Started
profalbert	Fri, 13 Feb 2009 22:25:12	Changed assigned to from None to profalbert
profalbert	Tue, 04 Nov 2008 08:08:47	Changed status from Fixed to Accepted
profalbert	Wed, 22 Oct 2008 07:36:15	Changed status from Accepted to Fixed
profalbert	Thu, 16 Oct 2008 07:01:40	Changed status from New to Accepted
cursesuckslots	Thu, 16 Oct 2008 05:16:16	Create

You must login to post a comment. Don't have an account? Register to get one!

12 comments
1
2
Next →

- #12
profalbert Mon, 10 Aug 2009 09:18:43
It has been a long time, but there is news about this:

I implemented a per-spell-filter system. (v1.8.3-7-ged678e2) Default-filters include "Ferocious Inspiration and Unleashed Rage", since the notifications for these spells are no use anyway.

If you can think of more filters that should be in Parrot by default, please create a ticket.
- #11
profalbert Tue, 03 Mar 2009 14:34:26
Try to increase the throttle for "skill damage". .1 is default yes.
- #10
theondry Tue, 03 Mar 2009 00:12:55
I throttle my DOTs and HOTs to 3 seconds. It doesn't seem to be so much the amount of spam coming through as the fact of it collecting information on all the stuff.
Other throttles are Heals, Killing Blows, Melee Damage all at 1 second. Power Gain/Loss at 3 seconds. Skill Damage at .1 seconds. (the default?)
I don't get any (significant) slow down *until* I drop Death and Decay and/or Pestilence my diseases onto a large group of mobs.
- #9
profalbert Wed, 25 Feb 2009 16:14:57
Diseases count as DoTs I think, so you could minimize that spam by throttling DoTs.
Per Spell Throttling is planned somewhere in the future, but has nothing to do with the issue described in in this ticket.

@Issue
The issue is when 2 players (i.e. 2 enhancer-shamans) overwrite the aura from one another all the time, so triggering 1 SPELL_AURA_REMOVED and 1 SPELL_AURA_APPLIED each time the buff is overwritten. That's every time Shaman A lands a critical hit, but Shaman B's buff is active (and vice versa).

Spells that are affected by this "bug" (It's imho a bug blizzard should be concerned about) are:
* Unleashed Rage (Enhancer shaman)
* Ferocious Inspiration (Beastmaster hunter)
(that's all of them I think)

I really need feedback on this issue, since I have difficulties to verify my attempts to fix it. I always add them in the alpha-builds.
Sadly for me the last weeks my raids always ended up with 1 enhancer-shaman (me) and no BM-hunter.
- #8
theondry Tue, 24 Feb 2009 06:20:51
I see a bunch of this happening in 10man and higher raids whenever there are a lot of mobs being affected by diseases and such. If I have Death and Decay up. If use Pestilence to spread diseases around, my framerate dies from all the spam.
- #7
profalbert Tue, 23 Dec 2008 18:50:54
I actually fixed it, when soloing the fix works as expected (refreshing Unleashed Rage doesn't show at all). but in groups with another enhancer shaman, the notifications show again as if nothing has changed. I need to group more often ;)
- #6
Xpl0iter Sat, 20 Dec 2008 08:37:59
I have the same bug, and I was wondering how CUrses got it fixed. Thanks in Advance!
- #5
profalbert Tue, 04 Nov 2008 08:10:57
so my shaman turned 70 at last, and I now expierienced the spamming myself.
The CPU-usage wasn't that bad, but the spamming is still there, so /reopen
- #4
cursesuckslots Wed, 22 Oct 2008 01:08:52
Appears to be working just fine. Good fix!
- #3
cursesuckslots Fri, 17 Oct 2008 16:43:21
THe spell aura thing was prettymuch a wag, I didn't really sit down and comb through the code. I'm probably not going to raid until Tuesday, but I'll have results for you then at the latest. May end up doing a Kara this weekend, so I'll report back if so.