Parrot

121 - Ticket 92 seems to be broken again

What steps will reproduce the problem?
1. Cast mend pet (hunter).
2.
3.

What is the expected output? What do you see instead?
Mend pet healing showing as incoming. It's now showing as both incoming and outgoing again.

What version of the product are you using?
Exact version: 1.10.4 (I think it broke in 1.10.3)
Locale: enGB

Are you using Parrot with embedded libs (if you don't know that means yes)?
Yes.

Do you have an error log of what happened?
No.

Please provide any additional information below.
None.

User When Change
profalbert Tue, 17 Nov 2009 11:01:09 Changed status from New to Invalid
InterClaw Fri, 30 Oct 2009 22:53:03 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of profalbert profalbert Mon, 23 Nov 2009 08:35:26

    That's because "Incoming" and "Outgoing" in the spell-filters-configuration does not correspond to the Scroll-area, but the event type. I suppose you want: all outgoing heals done by you, and all incoming heals received by your pet, with the exception: Mend pet should only be displayed as incoming. It's not possible to configure that. I'll think of a way to hide outgoing pet heals with an option.

    I can provide you with a temporary workaround: Replace the code of the checkPlayerOutHeal-function located in Parrot/Data/CombatEvents.lua:496-500 with this modified version.

    local function checkPlayerOutHeal(srcGUID, _, _, dstGUID, _, dstFlags, _, _, _, amount,
    		overheal)
    	return srcGUID ~= dstGUID and srcGUID == playerGUID and not checkFlags(dstFlags, PET_FLAGS)
    			and checkFullOverheal(amount, overheal)
    end
    

    Please submit a new ticket for the missing config.

    Last edited on 23 Nov 2009 by profalbert
  • Avatar of InterClaw InterClaw Sun, 22 Nov 2009 23:52:32

    Okay, I tried a spell filter instead. However, eventhough I just tick to filter Outgoing it seems to filter both incoming and outgoing. Now what? :/

  • Avatar of profalbert profalbert Sat, 14 Nov 2009 22:28:54

    "Mend Pet" is a heal done by the player. Outgoing Pet heals refers to Heals done BY the pet, not to the pet.

    This makes the ticket invalid ;)

    You may want to add a spell-filter for "Mend Pet".

  • Avatar of InterClaw InterClaw Sat, 14 Nov 2009 15:35:02

    "Outgoing Pet heals over time" actually was enabled, but disabling it did not have an effect. I have to disable "Outgoing Heals over time" for that. I think it might be because the skill Mend Pet is not counted as a pet skill or something. I think it should count toward pet heals, since it can only heal you own pet.

    Last edited on 14 Nov 2009 by InterClaw
  • Avatar of profalbert profalbert Sat, 31 Oct 2009 00:04:38

    This code hasn't been touched since 1.10 release. Check your settings, maybe you have both incoming and outgoing enabled.

    I just tested on my spirit wolves and everything worked fine.

  • 5 comments

Facts

Last updated on
17 Nov 2009
Reported on
30 Oct 2009
Status
Invalid - This was not a valid report.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees