84 - Rehash 42 - Fix number of visible bars calculation.
I read what you said in that other ticket, but that calculation isn't happening or something. When I get up to 10 bars, regardless of how big I've sized the frame, cooldowns are pushed off. Have you tested it with > 10 cooldowns showing?
http://img709.imageshack.us/img709/2142/cooldowns.jpg
That should be sized to fit more than 10 ... 19 actually, the next screenshot I photoshopped to clone the first bar as many times as would fit. I noticed this because I was looking for rebirth cooldowns and the other ones had pushed them off. Once one of the innervates at the top had fallen off, a new bar appeared at the bottom.
http://img43.imageshack.us/img43/5859/cooldowns2.jpg
http://www.wowace.com/addons/ora3/tickets/42-add-maximum-number-of-cooldown-bars-to-options-instead/
EDIT
I see where you're doing this...
maximum = math.floor(height / db.barHeight)
...inside of...
local function onResize(self, width, height)
...but, that maximum value isn't persisted. Does OnSizeChanged always fire every session that there isn't a user interaction? Something's not updating it. However, this time, I will try to resize the frame after I'm seeing the overflow behavior and see if it updates and shows more bars. That will at least make sure this works.
EDIT2
I was able to confirm this tonight. Resizing the frame while it overflowed and didn't show extras caused the extras to appear.
| User | When | Change |
|---|---|---|
| Pelf | Feb 22, 2011 at 03:28 UTC | Changed name from Rehash 42 - add maximum number of cooldown bars to options to Rehash 42 - Fix number of visible bars calculation. |
| Pelf | Feb 18, 2011 at 04:29 UTC | Changed description:...inside of... [code]local function onResize(self, width, height)[/code] ...but, that maximum value isn't persisted. Does OnSizeChanged always fire every session that there isn't a user interaction? Something's not updating it. However, this time, I will try to resize the frame after I'm seeing the overflow behavior and see if it updates and shows more bars. That will at least make sure this works. + + [b]EDIT2[/b] + + I was able to confirm this tonight. Resizing the frame while it overflowed and didn't show extras caused the extras to appear. |
| Pelf | Jan 21, 2011 at 00:04 UTC | Changed description type from Plain Text to BBCode Changed description: http://img43.imageshack.us/img43/5859/cooldowns2.jpg http://www.wowace.com/addons/ora3/tickets/42-add-maximum-number-of-cooldown-bars-to-options-instead/ + + [b]EDIT[/b] + + I see where you're doing this... + [code]maximum = math.floor(height / db.barHeight)[/code] + ...inside of... + [code]local function onResize(self, width, height)[/code] + ...but, that maximum value isn't persisted. Does OnSizeChanged always fire every session that there isn't a user interaction? Something's not updating it. However, this time, I will try to resize the frame after I'm seeing the overflow behavior and see if it updates and shows more bars. That will at least make sure this works. |
| Pelf | Jan 20, 2011 at 04:20 UTC | Create |
