oRA3

140 - New bug with Shaman Reincarnation CD

Just ran across a bug I hadn't seen before last night. When a shaman uses a warlock's Soulstone to res up, oRA3 puts up a new, full 30 minute ankh CD bar for the shaman, IF that shaman's ankh was already on CD.

Current code is this:

local start, duration = GetSpellCooldown(20608)
if start > 0 and duration > 1.5 then
  module:SendComm("Reincarnation", duration-1)
end

Which certainly does look like it would cause that specific problem. Unless I'm missing something, I believe the correct version would be:

local start, duration = GetSpellCooldown(20608)
if start > 0 then
  module:SendComm("Reincarnation", duration - (GetTime() - start))
end
User When Change
nebula169 Jun 23, 2013 at 00:16 UTC
ywfn Jun 20, 2013 at 11:51 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of ywfn ywfn Jun 23, 2013 at 03:32 UTC - 0 likes

    ah, i see. hadn't considered that possibility, and i removed that check when i put in the new check to make sure Reincarnation had just been used. but i just tested on a shaman, and the GCD doesn't show up as a cooldown when checking the Reincarnation cooldown, so i guess we're fine without it.

  • Avatar of nebula169 nebula169 Jun 23, 2013 at 00:13 UTC - 0 likes

    the duration check was there to make sure its not just the GCD that's showing as the cooldown, And the logic was fine taking out of account the fact that a shaman getting soulstoned wasn't considered :p

    Last edited Jun 23, 2013 by nebula169
  • Avatar of ywfn ywfn Jun 22, 2013 at 10:29 UTC - 0 likes

    oops, what i posted results in a bar of the wrong total length.

    much simpler fix is just to verify that reincarnation was used within the last couple seconds (that might have been the original intent of the "duration > 1.5"? but the logic is wrong...) will check in fix.

  • 3 comments

Facts

Last updated
Jun 23, 2013
Reported
Jun 20, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees