oRA3

103 - Ready Check update.

What steps will reproduce the problem?
1.Join LFR group
2.Initiate ready check
3.Only people in your own realm will update, everyone else shows with ? even though they responded ready.

What is the expected output? What do you see instead?
Only people in your realm will show as having checked ready, not ready etc

What version of the product are you using?
r516

Do you have an error log of what happened?
No errors show, just it doesn't seem to update or capture other people's responses in LFR groups.

Please provide any additional information below.

User When Change
Rabbit Dec 18, 2011 at 00:06 UTC
Rabbit Dec 08, 2011 at 13:53 UTC
Curace Dec 08, 2011 at 00:36 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Rabbit Rabbit Dec 21, 2011 at 11:09 UTC - 0 likes

    Thanks, think I got it now.

  • Avatar of oscarucb oscarucb Dec 21, 2011 at 10:50 UTC - 0 likes

    Ready check is still broken in LFR. Just ran one using r521 and still getting the exact same failure - all cross-realm toons show as "?" even after they've pressed ready.

  • Avatar of Rabbit Rabbit Dec 18, 2011 at 00:06 UTC - 0 likes

    Thanks, Takika! I went a different route and just removed server names from the ready check dialog completely.

    Next time, just commit to the source repository directly - it is open access.

  • Avatar of Takika Takika Dec 17, 2011 at 22:56 UTC - 0 likes

    You have to change ReadyCheck.lua, replace the original function with this:

    function module:READY_CHECK_CONFIRM(event, id, confirm)
    	-- this event only fires when promoted, no need to check
    	--oRA:Print(event, id, confirm)
    	local name, realm = UnitName(id)
    	if (realm) then
    		name = name .. "-" .. realm
    	end
    	if confirm then -- ready
    		readycheck[name] = RD_READY
    	elseif readycheck[name] ~= RD_OFFLINE then -- not ready, ignore offline
    		readycheck[name] = RD_NOTREADY
    	end
    	if self.db.profile.gui and frame then
    		updateWindow()
    	end
    end
    
  • 4 comments

Facts

Last updated
Mar 30, 2012
Reported
Dec 08, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees