!NoTaint - WoW AddOns

Reduce the chance that talent switching be forbidden.

These codes are based on very hard work of reviewing Blizzard's source code and testing taint status. The cause of the failure is rather complicated. As far as we know, there are 3 reasons at least.

1. Addon calls ToggleTalentFrame() to open talent panel.

2. Addon calls StaticPopup_Show()

3. Addon use UIFrameFlash()

4. Addon use ChatFrame_AddMessageEventFilter (related to reason 3.)

This addon can fix reason 1, 2 and 4. But for reason 3, there is no workaround fix, you have to modify the code where UIFrameFlash is called (or contact author to fix it).

You must login to post a comment. Don't have an account? Register to get one!

17 comments
1
2
Next →

- Reply
- #17
mysticalos Apr 05, 2013 at 07:32 UTC - 0 likes
staticpopup still taints, but it no longer blocks glyphs/talents. Although an issue could pop up some where else
- Reply
- #16
cremor Mar 19, 2013 at 16:58 UTC - 1 like
How is the situation since the 5.2 patch for WoW? I read somewhere that LibChatAnims is still needed, but what about the other points? Is it still suggested to have this addon installed if LibChatAnims is already provided by some other addon?
- Reply
- #15
Fylwind Feb 16, 2013 at 21:19 UTC - 0 likes
@funkydude: Go

I was not advocating removing the LibStub. I stripped it for testing only because LibStub loads after Code.lua so for the sake of simplicity I removed it.

In any case, the problem was my fault. I should've paid more attention to what you said earlier.
- Reply
- #14
funkydude Feb 16, 2013 at 20:05 UTC - 0 likes
@Fylwind, it would be useful if you answered some of the questions I asked the previous user. The entire point of using LibStub is to prevent re-hooking over and over again. Stripping it is NOT a good thing.
- Reply
- #13
warbaby Feb 16, 2013 at 13:20 UTC - 0 likes
@Fylwind: Go

try r14
- Reply
- #12
Fylwind Feb 15, 2013 at 05:34 UTC - 0 likes
So I just updated this addon recently and somehow I feel like I'm getting more taints than I had prior to the update. In particular, the addon will error out and tell me that some add-on has called UIFrameFlash, even though I greped the entire directory and found nothing of the sort. The stack-trace points to Blizzard code as far as I can tell (see below).

The error very reliably occurs when I receive a Battle.net whisper — which I have a second window for, so I suspect that's where the flash occurs. The source of the taint, though, appears to be ChatFrame_MessageEventHandler.

I copied the code from LibChatAnims.lua and pasted directly into Code.lua and surprisingly it works now (after stripping the LibStub boilerplate). So it seems that the hack doesn't work for some reason when embedded as a library, but works fine if placed directly in the code for !NoTaint.
7x !NoTaint-r12\Code.lua:71: AddOn calls UIFrameFlash, you may not be able to switch talent. <in C code> !NoTaint-r12\Code.lua:71: in function <!NoTaint\Code.lua:68> <in C code> FrameXML\FloatingChatFrame.lua:1376: in function <FrameXML\FloatingChatFrame.lua:1368> <in C code> FrameXML\ChatFrame.lua:3298: in function "ChatFrame_MessageEventHandler" FrameXML\ChatFrame.lua:2761: in function <FrameXML\ChatFrame.lua:2754> (tail call): ? <string>:"*:OnEvent":1: in function <string>:"*:OnEvent":1
- Reply
- #11
funkydude Feb 10, 2013 at 19:09 UTC - 0 likes
@Winney1907
If you're running with disembedded libraries, try r14. If not, for some reason LibChatAnims hasn't loaded for you. Did you update whilst in game? If so, exit wow first.

Winney1907 Feb 10, 2013 at 18:46 UTC - 0 likes

Been getting this error with r13.

Date: 2013-02-10 18:44:16
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\!NoTaint\Code.lua line 71:
   AddOn calls UIFrameFlash, you may not be able to switch talent.
Debug:
   [C]: error()
   !NoTaint\Code.lua:71:
      !NoTaint\Code.lua:68
   [C]: UIFrameFlash()
   ..\FrameXML\FloatingChatFrame.lua:1376: FCF_StartAlertFlash()
   ..\FrameXML\ChatFrame.lua:3298:
      ..\FrameXML\ChatFrame.lua:2949
   (tail call): ?
   (tail call): ?
   ..\FrameXML\ChatFrame.lua:2761:
      ..\FrameXML\ChatFrame.lua:2754
   [C]: pcall()
   Stubby\Stubby.lua:379:
      Stubby\Stubby.lua:325
   (tail call): ?
   [string "*:OnEvent"]:1:
      [string "*:OnEvent"]:1
Locals:
(*temporary) = "AddOn calls UIFrameFlash, you may not be able to switch talent."

- Reply
- #9
mysticalos Jan 30, 2013 at 18:41 UTC - 0 likes
i don't doubt. just odd. I have all my guildies run this so we can raid with no taints and not be held up by reloads every boss fight to change talents and glyphs. Works fine

only DC bug people get is the rez bug that knocks you offline from desync for no real good reason that started in 5.1 :\
- Reply
- #8
myrroddin Jan 30, 2013 at 07:51 UTC - 0 likes
@mysticalos: Go

There was a lot of lagged game textures, lag on zoning or crossing map zones (Towlong Steppes to Dread Waste by flying, for example) followed by "disconnected from server". It didn't seem to matter where I was flying from or to, or where I logged into the game. I could log into Stormwind or Shrine of the Seven Stars or Halfhill; lag, lag, disconnect.