You must login to post a comment. Don't have an account? Register to get one!

• 

  • #72

  fyrye Fri, 30 Oct 2009 10:53:52

  No word since August, mine seems to be working fine, but I made changes to the core to work with my Addon Compilation, so unless I get bored and decide to cancel my 4 other projects I have planned, I won't be re-writting nQuestlog. Updating it from Ace2 to Ace3 would be a hassle. Ontop of it re-writting it to work with Quixote2 is another hassle.

  I will post fixes for issues like I have in the past if I continue to play WoW, but no new features.

• 

  • #71

  GRiMoku Fri, 23 Oct 2009 00:38:46

  WTB - Achievement tracking! :)

• 

  • #70

  kappesante Mon, 19 Oct 2009 07:08:35

  any news guys?

• 

  • #69

  Corlandith Sun, 20 Sep 2009 17:41:01

  Nevermind... I R Stupid some days... found what I needed

  thanks folks C

  Last edited on 20 Sep 2009 by Corlandith
• 

  • #68

  Highend Wed, 09 Sep 2009 08:46:59

  Thanks fyrye for posting these fixes! nQuestLog is one of the most important WoW addons for me :)

  Regards, Highend

• 

  • #67

  ichik Mon, 07 Sep 2009 18:22:42

  Currently fyrye clone works much better than r237.

  Last edited on 07 Sep 2009 by ichik
• 

  • #66

  casualblair Thu, 03 Sep 2009 03:52:06

  Working on it right now.

• 

  • #65

  harl Thu, 03 Sep 2009 02:12:20

  I'm glad to see that someone's taking care of nQuestLog, since it's been one of my overall favourite add-ons.
  Is there some kind of a latest build available for those few of us who don't like dabbling in code they don't understand? Or can one of you who has already incorporated the most-necessary changes upload his or her version as a temporary update please?

• 

  • #64

  fyrye Thu, 20 Aug 2009 19:01:41

  As for the Blizzard Frames Fix for GRiMoku, since they made it double wide, they changed the handling for the frames that hold the quest title text My clone added a hack for this which emulates the way blizzard changed it The other way, for some odd reason, when you scroll, the level info would disappear.

  self:SecureHook("HybridScrollFrame_Update") -- Add to ToggleEnabled
  --and
  self:Unhook("HybridScrollFrame_Update") --add to the other unhooks
  
  --Add this function somewhere
  function BlizzardFrames:HybridScrollFrame_Update()
  	self:QuestLog_Update()
  end
  

  --change QuestLog_Update()
  local numButtons = #buttons;
  local scrollOffset = HybridScrollFrame_GetOffset(QuestLogScrollFrame);
  local titleLine, questLogTitle, questTitleTag, questNumGroupMates, questNormalText, questCheck;
  local titleLineWidth, questTagWidth, questTitleWidth
  for i=1, numButtons do
  	titleLine = buttons[i];
  	questIndex = i + scrollOffset;
  	titleLine:SetID(questIndex);
  	questTitleTag = titleLine.tag;
  	questNumGroupMates = titleLine.groupMates;
  	questCheck = titleLine.check;
  	questNormalText = titleLine.normalText;
  	
  	if ( titleLine ) and ( titleLine:GetText() ) then
  		local title, level, tag = Quixote:GetQuest(titleLine:GetText():trim())
  		if ( title ) then
  			local questLevel = "["..level..tag.."] "..title 
  			titleLine:SetText(questLevel)
  			--hack to fix new way text in the questLogFrame is handled
  			titleLineWidth = titleLine:GetWidth()
  			questTagWidth = questTitleTag:GetWidth()
  			questTitleWidth = questNormalText:GetWidth()
  			if( questTitleWidth+30 < titleLineWidth-questTagWidth ) then
  				questNormalText:SetWidth(questTitleWidth+30);
  			end
  		--No clue what this is for, assuming quest check marks for tracking.
  		--Updated to how Blizzard Shows theirs now
  			if ( IsQuestWatched(questIndex) ) then
  				questCheck:Show();
  			else
  				questCheck:Hide();
  			end
  		end
  	end
  end
  

  Last edited on 20 Aug 2009 by fyrye
• 

  • #63

  fyrye Thu, 20 Aug 2009 18:38:21

  Just a heads up.
  When accepting a Quest of type Player, it effectively breaks nQuestLog's tracker
  I added a hack to nQuestLog on my end but haven't shared it due to my any different changes since my clone's post.
  The real way to fix it is in Quixote which determines the output.
  Since Quixote-1.0 is disconintued, ill post both fixes here, since I don't know how to create a patch file correctly.. yet.
  You only need to use 1, Quixote is the actual fix, while the hack is just a workaround to not break it when picking up a player quest type

  Quixote *FIX*:

  --@ Line 329, Quixote-1.0.lua
  elseif qtype == 'player' then
   --This should go up higher, no need to check faction for each player quest call
  local faction = UnitFactionGroup("player")
  numItems, numNeeded = deformat(desc, QUEST_PLAYERS_KILLED)
  if faction == 'Alliance' then
  	opfaction = 'Horde'
  else
  	opfaction = 'Alliance'
  end
  desc = opfaction .. " players slain"
  mobs[desc] = ("%s: %d/%d"):format(desc, numItems, numNeeded)
  

  nQuestLog *HACK*: nQuestLogCore.lua Line: 293

  if ( strType == "reputation" or strType == "player" ) then
  	iNeeded = 1
  	iGot = 0
  	if ( isDone ) then
  		iGot = 1
  	end
  end
  

  Last edited on 20 Aug 2009 by fyrye