Mylune's Champions

4 - Use custom companion pet names rather than default pet name/species

What steps will reproduce the problem?
1. Give a pet a custom name. (eg: rename your "Stinky Skunk" to "McStinkyPants" in the UI)
2. Summon it.
3. Run /pe or otherwise generate an emote.

What is the expected output? What do you see instead?

I saw this:

Larelina's companion Stinky Skunk loves you.

I expected to see this:

Larelina's companion McStinkyPants loves you.

What version of the product are you using?

Version: 0.8.1
X-Date: $Date: 2013-09-11 21:40:10 +0000 (Wed, 11 Sep 2013) $
X-Curse-Packaged-Version: v0.8.1

Please provide any additional information below.

This is fixed by changing util_companions.lua:153 in function MylunesChampions:GetCurrentCompanion() to return the customName if available; something like this: return customName or petName, creatureID where you currently return petName, creatureID.

User When Change
nyyr Dec 16, 2013 at 10:11 UTC Changed status from New to Accepted
slippycheeze Dec 15, 2013 at 16:17 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of nyyr nyyr Dec 17, 2013 at 14:54 UTC - 0 likes

    I think I'm able to add this to my next commit (since you already were quite detailed). Testing is still necessary and needs to consider emotes targeted at your companion.

  • Avatar of slippycheeze slippycheeze Dec 16, 2013 at 18:04 UTC - 0 likes

    Would you accept a patch if I tested and submitted it? Do you prefer some method other than attached here? I can definitely test the fix and make sure it works. :)

  • Avatar of nyyr nyyr Dec 16, 2013 at 10:11 UTC - 0 likes

    Thanks for the suggestion. ETA maybe in January.

  • 3 comments

Facts

Last updated
Dec 16, 2013
Reported
Dec 15, 2013
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees

  • Avatar of nyyr
    • Manager
    • Author