Mylune's Champions

3 - Make the "mount/companion/pet" preface optional...

Right now Mylune's Champions produces messages that look like this:

Larelina's companion Stinky Skunk loves you.
Larelina's mount Giant Horse plays poker.

That actually reads as a pretty cumbersome sentence to me; I would much rather it dropped the "companion", "mount", etc, string saying what sort of thing it was, and just posted the emote:

Larelina's Stinky Skunk loves you.
Larelina's Giant Horse plays poker.

That is, in util_companions.lua:93, change from local preface = self.LG["COMPANION"] .. name .. " " to local preface = name .. " ". (Plus the corresponding changes to mounts and pets, I imagine. :)

User When Change
nyyr Dec 16, 2013 at 10:10 UTC Changed status from New to Accepted
slippycheeze Dec 15, 2013 at 16:09 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of nyyr nyyr Dec 17, 2013 at 14:52 UTC - 0 likes

    Yes, feel free to create a patch. A configuration option is mandatory, though (default: display additional preface). Reason is some gender / grammatical issue in German in some cases.

    I'm not yet sure whether this should be a global option or an option per pet/mount. What do you think?

    Do you have any lua-references (own projects)?. If so, I could consider adding you as a contributor if I'm convinced by you coding style and if you like ;)

  • Avatar of slippycheeze slippycheeze Dec 16, 2013 at 18:01 UTC - 0 likes

    Would you accept a patch if I wrote one -- either adding an option for this, or just making the change unconditionally? If so, would you indicate which is preferable? (Also, if you prefer some method other than patch attached here ;)

  • Avatar of nyyr nyyr Dec 16, 2013 at 10:10 UTC - 0 likes

    Thanks for the suggestion. ETA maybe in January.

  • 3 comments

Facts

Last updated
Dec 16, 2013
Reported
Dec 15, 2013
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees

  • Avatar of nyyr
    • Manager
    • Author