MultiTool

5 - Incorrect inventory space warning

What steps will reproduce the problem?
1. Loot something that stacks

What is the expected output? What do you see instead?
Expected: No inventory space warning, since number of available slots hasn't changed
Instead: I get a warning whenever I loot simething -.-

Please provide any additional information below.
A possible fix would be using UNIT_INVENTORY_CHANGED instead of ITEM_PUSH as this one _really_ only fires when the number of available slots changes. ITEM_PUSH fires also when an item stacks and is therefore not the best choice here. Otherwise, some more logic checks would be needed.

User When Change
ckaotik May 04, 2012 at 10:47 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of DigitalSorceress DigitalSorceress Nov 27, 2012 at 19:57 UTC - 0 likes

    WOW, I'm only what? 8 months behind... sorry.

    Personally, I like the warning even on stacking items because the intent (for me) was to give a warning whenever I add stuff to or attempt to add stuff to my bag and the remaining space threshold is past. This is really useful for multiboxing because full bags should be a stone in my shoe - I WANT to be reminded every time I try and put something in that I have 0 or < n spots left whether the item fit or not.

    However, I will see if I could come up with a way to signal you want 'less spammy" notification... assuming the UNIT_INVENTORY_CHANGED actually fires when I want it to.

  • 1 comment

Facts

Reported
May 04, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees