MorgDKP2

85 - EQDKP plugin item id not beeing added.

When adding a raid though the EQDKP plugin, and MultiDKP is not selected, the ItemID is not added to the database.
This means that Itemstats (in EQDKP+) will instead use the name to search for the item on wowhead/armory, which in turn results in linking to the Heroic version even when it's the normal version you have recived.

This do however work properly while using MultiDKP.

I have already found the reason for this, it's a small error in MorgFunc2.php. Row 434-436 currently look like this:

$sql = "INSERT INTO " . $table_prefix . 'items' . " (item_name, item_buyer, raid_id, item_value, item_date, item_added_by, item_group_key)
	VALUES ('" . rtrim($loot['ItemName']) . "','" . rtrim($loot['Player']) . "','$raid_id','" . $loot['Costs'] . 
		"','$loottime','$user','$groupkey')";

The correct code should instead look like this (similar to how it looks for MultiDKP):

$sql = "INSERT INTO " . $table_prefix . 'items' . " (item_name, item_buyer, raid_id, item_value, game_itemid, item_date, item_added_by, item_group_key)
	VALUES ('" . rtrim($loot['ItemName']) . "','" . rtrim($loot['Player']) . "','$raid_id','" . $loot['Costs'] . "','" . $loot['ID'] .
		"','$loottime','$user','$groupkey')";

Hope that you can fit this into the next version, so that noone else have to spend an hour manually adding itemID's to old items to make it look right :)

Thanks!
Simon

User When Change
Morgalm Mar 14, 2010 at 23:54 UTC Changed status from New to Fixed
nosscire Mar 14, 2010 at 15:13 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Morgalm Morgalm Mar 14, 2010 at 23:54 UTC - 0 likes

    Your fix doesn't work as it then breaks eqdkp compatibility. But I added a fix that works properly thanks for the heads up:)

  • 1 comment

Facts

Last updated
Mar 14, 2010
Reported
Mar 14, 2010
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees