Mapster

158 - Tried to call protected function

What steps will reproduce the problem?
1. attack something or summon pet while alone or in a party
2. or attempt to place a raid marker while in a raid
3.

What is the expected output? What do you see instead?
Nothing to happen

What version of the product are you using?
Mapster 1.5.4-1

Do you have an error log of what happened?
459x [ADDON_ACTION_BLOCKED] AddOn "Mapster" tried to call the protected function "CompactPartyFrameMember1:Show()".
!BugGrabber-r191-release\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
FrameXML\CompactUnitFrame.lua:279 in function "CompactUnitFrame_UpdateVisible"
FrameXML\CompactUnitFrame.lua:237 in function "CompactUnitFrame_UpdateAll"
FrameXML\CompactUnitFrame.lua:47 in function <FrameXML\CompactUnitFrame.lua:44

Locals:
nil

30x [ADDON_ACTION_BLOCKED] AddOn "Mapster" tried to call the protected function "CompactPartyFrameMember1:SetAttribute()".
!BugGrabber-r191-release\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
FrameXML\CompactUnitFrame.lua:264 in function "CompactUnitFrame_UpdateInVehicle"
FrameXML\CompactUnitFrame.lua:236 in function "CompactUnitFrame_UpdateAll"
FrameXML\CompactUnitFrame.lua:97 in function <FrameXML\CompactUnitFrame.lua:44

Locals:
nil

Those error are from a fresh install with only Mapster and buggrabber running, while trying to do my farm on my hunter, surely throwing that many errors repeatedly every day for 6 months is long enough, I really like Mapster but to be honest I'm getting sick of having to reload my UI in raids and have LUA errors thrown while trying to do anything when it's the only thing that's loaded.

Please provide any additional information below.

Was reported 6 months ago in 1.5.2 and was told another addon was causing this issue despite bug grabber being the only other addon installed with just the Blizzard addons, even without any other addons installed this is still the case and has been on multiple computers and multiple installs with only a fresh WoW and Mapster installed

Now before you once again mark this as invalid can you care to provide an explanation as to why with Mapster loaded it throws these LUA errors repeatedly and prevents raid markers from being placed until a reload of the UI is preformed, and no errors are thrown with it turned off?

User When Change
Nevcairiel Oct 17, 2014 at 22:00 UTC Changed status from New to Declined
majikthise Sep 03, 2013 at 19:07 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 9 comments
  • Avatar of Nevcairiel Nevcairiel Oct 17, 2014 at 22:00 UTC - 0 likes

    Much has changed in Mapster since 6.0, please re-open if this is still a problem.

  • Avatar of Aiue Aiue Oct 19, 2013 at 17:50 UTC - 0 likes

    Disabling all modules except for Coordinates seems to fix the taint issue.

    Just reenabled instance maps, will report back if I start getting taint issues again. (I only seem to be getting them while grouped and in combat.)

  • Avatar of majikthise majikthise Sep 29, 2013 at 17:20 UTC - 0 likes

    Well you could start with a line by line run through of the code checking each array and making sure no external calls are being made and that only given and useful functions are there, in the similar sort of way the "drop down box" was calling wrong. Don't think me naive I do understand and work with code so I am fully aware that it is not a simple and none laborious task, however this addon is old and still using a lot of liibaries like Acehook or callback did you ever consider that maybe that is the cause? I'm sure that there are dead bits of code lying around, or that is isn't really optimised, maybe you should take this opportunity while line by lining to do that

    As for the reproduction I haven't had time to check it with deps disabled but if you want the steps they are posted at the top of the page, my personal favourite is on my hunter have pet out and just try and pull weeds and get errors as soon as it gets into vehicle mode. So that might be a place for you to start looking for errors in the code considering you are adjusting one of the biggest frames in the game outside of the quest log. TBH I don't know what more to say beyond just play for any period of time and it will error eventually if not immediately on combat or vehicle mode

    Given that you aren't really making any attempt outside of asking me to do the work for you on an age old bug I'm reaching the point where I might as well use a fully updated and maintained mapmod over this one that dismisses issues as other peoples problem for over a year. Since your last response I turned it off anyway to clear the issues

    Last edited Sep 29, 2013 by majikthise
  • Avatar of Nevcairiel Nevcairiel Sep 20, 2013 at 08:55 UTC - 0 likes

    I don't know how you imagine "checking for potential issues" works, but without being able to reproduce and debug such issues, its basically impossible to find the exact source. Taint issues are not like normal issues.

    Anyhow, if you want to help track it down, since you seem to be able to reproduce it just by logging in, you can disable some of Mapsters modules (Instance Maps, FogClear, GroupIcons, Coordinates) and see if one of these is possibly responsible, or if it still happens with all of them off (most likely candidates would be FogClear or InstanceMaps)

    Additionally, if you can find a clear way to make it happen 100% from a fresh login, please describe the steps you take, no matter how minor they seem. Preferably a way that doesn't require a raid or group, since it also seems to happen without one, unless i misread something.

  • Avatar of majikthise majikthise Sep 19, 2013 at 20:19 UTC - 0 likes

    OK then how come with just a fresh install and Mapster and no other addons other then Blizzards own those errors are still thrown into chat until the point that I receive the "your addons are causing too many errors your play experience may be diminished"

    Deleting the Blizzard addons to reset them does not help, only removal of Mapster stops these errors and allows me to use all the frame functions like raid flags or even pick weeds on my farm with no errors.

    These errors only happen when Mapster is on and don't when Mapster is off, if I run all my other addons without Mapster then there is no issue, I then turn Mapster back on and bam errors until the cows come home. However as I have repeatedly pointed out these errors only happen when Mapster is on and when it's the only thing that is on other then the Blizzard addons. Even on a fresh install with only Mapster as the singular installed addon.

    So you must have a hook or something that is tainting otherwise it wouldn't only be happening with Mapster as the only addon running.

    As for the "If it doesn't happen for me, i can do nothing about it." nothing is stopping you checking for potential issues in the code, you don't need to have the error happen for that. Not to mention the error always gives the same error response in the same functions.

    The "Compact frames error" is just repeated for each frame from 1 - 8 and these errors are identical to the errors from ticket 128 for October 2012 in which Dridzt tried to help you track down the issue yet it still remains

  • Avatar of Nevcairiel Nevcairiel Sep 17, 2013 at 17:21 UTC - 0 likes

    Oh and more importantly, if i cannot reproduce an error, i cannot fix it - if it exists or not is irrelevant. If it doesn't happen for me, i can do nothing about it.

  • Avatar of Nevcairiel Nevcairiel Sep 17, 2013 at 17:18 UTC - 0 likes

    Thats not a "card". I run Mapster, i can use these functions, therefor its not Mapster alone thats causing the issue.

    An important fact to note is that the addon being blamed by WoW is in like 90% of the cases not the addon actually causing the issue. Tracking the taint correctly is nearly impossible.

  • Avatar of majikthise majikthise Sep 17, 2013 at 17:00 UTC - 0 likes

    @Nevcairiel: Go

    then maybe you should check tickets 128, 139, 141

    This is a known issue that has been around for ages and repeatedly reported.

    If you don't know why then just say so, but don't pull the "it doesn't happen to me therefore it doesn't exist" card

  • Avatar of Nevcairiel Nevcairiel Sep 17, 2013 at 12:58 UTC - 0 likes

    Never seen any of these issues myself when running Mapster.

  • 9 comments

Facts

Last updated
Oct 17, 2014
Reported
Sep 03, 2013
Status
Declined - We decided not to take action on this ticket.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees