MalygosStacks

2 - Patch to make it work in 3.1 german

The patch uses the new API of UnitDebuff and makes the addon load in the german client if AddonLoader is used

Index: MalygosStacks.lua
===================================================================
--- MalygosStacks.lua  (revision 23)
+++ MalygosStacks.lua  (working copy)
@@ -118,16 +118,18 @@
             --ramp up alpha wrt energy from 30 to 50, providing a visual jump (.68 -> 1) at 50
             self.frame.background:SetVertexColor(1 1, 1, max(0.3, (power-15)*2/100))
         end
+        expirationTime = 0
+        debuffStacks = 0
+        for i=1,40 do
+            local name, _, _, count, _, _, etime, caster = UnitDebuff("target", debuffName)
+            if caster == "vehicle" then
+                if name then
+                    expirationTime = etime
+                    debuffStacks = count
+                end
+            end
+        end
         
-        local name, _, _, count, _, _, etime = UnitDebuff("target", debuffName, "", "PLAYER")
-        if name then
-            expirationTime = etime
-            debuffStacks = count
-        else
-            expirationTime = 0
-            debuffStacks = 0
-        end
-        
         local remaining = expirationTime - GetTime()
         if debuffStacks and remaining >= 0 then
             local color = "00FF00"
Index: MalygosStacks.toc
===================================================================
--- MalygosStacks.toc  (revision 23)
+++ MalygosStacks.toc  (working copy)
@@ -9,7 +9,7 @@
 ## X-Category: Raid
 
 ## LoadManagers: AddonLoader
-## X-LoadOn-Zone: The Nexus, The Eye of Eternity
+## X-LoadOn-Zone: The Nexus, The Eye of Eternity, Der Nexus, Das Auge der Ewigkeit
 
 #@no-lib-strip@
 embeds.xml

User When Change
nebula169 Fri, 07 Aug 2009 22:21:12 Changed status from Invalid to Declined
nebula169 Fri, 07 Aug 2009 22:20:53 Changed status from Waiting to Invalid
nebula169 Thu, 16 Jul 2009 20:38:49 Changed status from New to Waiting
Flyhard Fri, 03 Jul 2009 07:08:42 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of nebula169 nebula169 Fri, 28 Aug 2009 13:11:13

    This is now fixed in AddonLoader

  • Avatar of nebula169 nebula169 Thu, 16 Jul 2009 20:35:54

    I am using the updated API for UnitDebuff as I indicated in my commit from April. You couldn't use UnitAura at all for vehicles before 3.1. The "PLAYER" filter was changed to include your vehicle (and other minions) in the 3.1 patch.

    As far as AddonLoader is concerned, the X-LoadOn-Zone strings are supposed to be in English. It then uses LibBabble-Zone to get the proper translations. However! It seems therein lies the issue.

    Open Interface\AddOns\AddonLoader\Conditions.lua and on line 281 change

    BZ = LibStub and LibStub("Babble-Zone-3.0", true)
    

    to

    BZ = LibStub and LibStub("LibBabble-Zone-3.0", true)
    

    I've submitted a ticket to AddonLoader about it.

  • 2 comments

Facts

Last updated on
07 Aug 2009
Reported on
03 Jul 2009
Status
Declined - We decided not to take action on this ticket.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.

Reported by

Possible assignees