MagicDKP [Deprecated for MOP]

29 - Allow whisper response with negative DKP

What is the enhancement in mind? How should it look and feel?
A pretty simple enhancement that will allow DKP responses with negative DKP. Our guild uses a Fixed Prize System and so there can be players with dkp < 0. They only get the table where they have dpk > 0 as response.

The enhancement is relative easy to implement. For now I have changed Line 438 from:

if dkp and dkp > 0 then

to

if dkp then -- and dkp > 0 then

it works for me but there will probably be the need do make a Checkbox to enable and disable the feature.

Think about it.

by sway

User When Change
dhedbor May 18, 2009 at 22:24 UTC Changed status from New to Accepted
swayenvoy May 13, 2009 at 16:43 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of dhedbor dhedbor May 18, 2009 at 22:24 UTC - 0 likes

    It's not a hard thing to support. As I mentioned in another ticket, I simply didn't envision this being used in a fixed DKP system. I plan to go through the system and improve it for fixed dkp and negative dkp systems.

  • Avatar of jafo12 jafo12 May 16, 2009 at 01:28 UTC - 0 likes

    I would agree, I would like to see the system handle negative dkp.

    I made the same change, there are other parts that seem to not support negative dkp, as an example the whipser function for current dkp does not support negative values ever with the above change mentioned.

  • 2 comments

Facts

Last updated
Mar 30, 2012
Reported
May 13, 2009
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees