LilSparky's Workshop

15 - Add profit (cost) per skillup sort

What does the provided patch do?
Adds a new sort option, sort by profit/cost skill up point

Please provide any additional information below.
This works fine on my system, but looking probably needs more cleanup, as it is calling a function from skillet in the LSW core.

Name Size MD5
lsw.patch 4.6 KiB e257588e8c83e5a38f9605f2c09992a5
User When Change
lilsparky Sat, 15 Aug 2009 22:38:15 Changed status from Accepted to Fixed
lilsparky Tue, 16 Jun 2009 05:43:38 Changed status from New to Accepted
riveth_ Mon, 15 Jun 2009 16:01:39

Added attachment lsw.patch

riveth_ Mon, 15 Jun 2009 16:01:31 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of lilsparky lilsparky Tue, 14 Jul 2009 23:30:31

    so the skill up factor stuff should work now. it requires libpt for the data in order to be enabled as an option.

  • Avatar of riveth_ riveth_ Wed, 17 Jun 2009 03:43:53

    Ah, I think I saw the beginnings of that in the code, but I wasn't sure the intent.

    As for libperiodictable, I'm not honestly a big fan of the interface. As you can see, I had to wrap it to do double lookups in some cases, due to the way they organize the data. I think ARL has a copy of the data as well; I'll poke and see if it is better organized.

  • Avatar of lilsparky lilsparky Tue, 16 Jun 2009 05:43:35

    actually, i my intention is to add a "skill up factor" flag (using the same linear progression estimate). it would adjust all item costs by dividing by the skill up %.

    i'm still debating whether i want to include the skill levels data as part of lsw or whether i would make lsw rely on libperiodictable (as my skillet clone does for it's skill up numbers).

  • 3 comments

Facts

Last updated on
15 Aug 2009
Reported on
15 Jun 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.

Reported by

Possible assignees