LibStatLogic-1.2

41 - Hunter agility per crit wrong

The agility to crit calculations seem to be very off, my ranged weapon is showing as adding a total of 11.61% crit, with 10.73% of that coming from agility, in reality this weapon only increases my crit percentage by a total of 1.75% crit.

Is there any way I can help assist in getting these values correct?

I'm a level 90 Pandren Hunter

User When Change
mikari Oct 05, 2012 at 15:52 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 8 comments
  • Avatar of JackTripper JackTripper Oct 06, 2012 at 22:48 UTC - 0 likes

    <<reply 993435="">>

    i checked in a change for "Crit from Agility" for a level 90 hunter.

  • Avatar of mikari mikari Oct 06, 2012 at 18:14 UTC - 0 likes

    All the rating stuff, including haste added in r173 checks out perfectly in game. Once the agility per crit is in the addon should be pretty much 100% accurate for level 90 Hunters.

    Thanks so much for all the work you're putting in updating the library.

  • Avatar of JackTripper JackTripper Oct 06, 2012 at 17:34 UTC - 0 likes

    The relavent Hunter Critical Strike values at level 90 are:

    critChance = -1.53 + agility/1259.51809 + critRating/600
    

    If agility and crit rating are not enough to get you at least 1.53% Crit Chance (making the above formula negaive), then the value caps at zero:

    critChance = max(critChance = -1.53 + agility/1259.51809 + critRating/600, 0)
    

    Now i just have to find the spot in LibStatLogic that deals with

    • agility per crit
    • base crit chance being negative
    • lower cap at 0%

    and work it all in.

  • Avatar of JackTripper JackTripper Oct 06, 2012 at 16:52 UTC - 0 likes

    <<reply 993100="">>

    Does this make sense?

    • Crit Rating: 880 (Increases Critical Chance by 1.47%)
    • Crit Chance: 0.96%

    sdf

    That sounds very strange on Blizzard's part.

  • Avatar of mikari mikari Oct 06, 2012 at 14:29 UTC - 0 likes

    I have the data from Tank Points but I don't have Excel on this machine and don't seem to be able to save the data as a CSV, trying to import the data into Open Office isn't giving me columns and such.

    Here's the data directly from the LUA file with the leading and trailing stuff stripped though.

    https://docs.google.com/open?id=0B7DJzW7d1MCRZ0tSa1Bqb1RldjA

    [edit]

    Think I may have managed to do it properly now.

    https://docs.google.com/spreadsheet/ccc?key=0ArDJzW7d1MCRdFVGUkx3ajJpTW1iai10N2tKTmROblE

    Last edited Oct 06, 2012 by mikari
  • Avatar of JackTripper JackTripper Oct 06, 2012 at 13:39 UTC - 0 likes

    <<reply 992653="">>

    Something is wrong.

    Mixed in with the rows of data is a "header" row:

    PlayerLevel PlayerClass PlayerRace  SpecializationIndex MasterySpell    ShapeshiftForm  Strength    BaseStrength    Agility BaseAgility Stamina BaseStamina Intellect   BaseIntellect   Armor   DodgeRating DodgeRatingBonus    DodgeChance Free Dodge  DR Dodge    Dodge Theo  ParryRating ParryRatingBonus    ParryChance Free Parry  CritRating  CritRatingBonus CritChance  BlockRating BlockRatingBonus    BlockChance MasteryRating   MasteryRatingBonus  Mastery MasteryEffect   MasteryFactor   MeleeHitRating  MeleeHitRatingBonus MeleeHitChance  SpellHitRating  SpellHitRatingBonus SpellHitChance  MeleeHasteRating    MeleeHasteRatingBonus   MeleeHaste  DR Parry    Parry Residual
    

    Ideally you would cut/paste that row to the top. But if i take the header from anyone else, it looks like columns are missing. e.g.

    • the first column should be playerLevel, but it's not there

    If i ignore that, and assume only that column is missing, then other values make no sense:

    screenshot

    There's no way you have a crit chance of over 1000 percent.

    Also, and this is a google spreadsheet issue, your spreadsheet has 50 rows - exactly 50 rows. If you want to add more you have to scroll to the bottom and click to add more.


    The way i usually transfer the stuff into a google spreadsheet is to

    • strip off the leading and trailing lua stuff, leaving only comma separated values
    • first save it as CSV
    • open the CSV in Excel (as Google doesn't know how to open a CSV file)
    • move the header row to the top
    • select all
    • paste into google
    • if google complains that it can only paste 50k at a time, then i copy 5 or 10 columns at a time.
  • Avatar of mikari mikari Oct 06, 2012 at 07:18 UTC - 0 likes
  • Avatar of JackTripper JackTripper Oct 05, 2012 at 19:20 UTC - 0 likes

    There definitely is a way you can help.

    What we need are a lot of numbers giving your:

    • Agility (e.g. 1172)
    • base Agility (e.g. 97)
    • Crit Rating (e.g. 2174)
    • Crit Rating Bonus (e.g. 1.75%)
    • Crit Chance (e.g. 21.62%)

    And we need those for as many different items equipped as you can stand, i.e.:

    • over a large range of Agility (all your agility gear on, down to naked and just your base agility)
    • over a large range of Crit Rating (all your crit gear on, down to naked and zero crit rating)

    The additional problem is that the percentages shown in your tooltip only show two decimal places. While this is better than nothing, it's not good enough. So you'll have to type a command to output the full value:

    /dump GetCombatRatingBonus(CR_CRIT_RANGED)
    1.759265358979
    
    /dump GetCritChance()
    21.6259230781
    

    i got sick of typing these commands, and typing them out into Excel, so i added the capability to another addon a wrote. Read about it here and follow those instructions.

  • 8 comments

Facts

Reported
Oct 05, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees