LibStatLogic-1.2

40 - Error with frFR at startup

LibStatlogic return an error at startup in french (and probably few other languages).

This is caused because there is no StatIDLookup in frFR locales
This can be fixed by adding a blank setup in the locale (line 177)

["StatIDLookup"] = {
}

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

On a side note, I have a trouble with critRating in frFR with ratingbuster. I didnt check all the code so maybe you can give me an insight:

With debug, I can see the pattern "Score de coup critique" (that is the name in frFR) is found in libstatlogic, (it's also listed in the summarize section of Rating Buster tooltip)

but I can't have the rating displayed in the original stat line with ratingBuster (I have all other stats displayed correctly but that one).
I have tried few adjustments in RB locale, with no luck.

After some investigation, I saw that in globalstring the critrating can have two names in frFR
Long: "score de coup critique"
Short: "score de critique"
can this be the cause of the trouble? is so, any idea how I can fix it?

(sorry for my frenchy english)

Name Description Size MD5
frFR.zip frFR locale for SL 7.7 KiB fa149a0d9ab4...
RB_frFR.zip frFR locales for RB 8.4 KiB 01a0f5396b98...
  • LogicRB.jpg
    LibLogic
  • 166.jpg
    rev166
User When Change
Tixu Oct 02, 2012 at 13:22 UTC

Added attachment RB_frFR.zip

Tixu Oct 02, 2012 at 10:40 UTC

Added attachment frFR.zip

Tixu Oct 01, 2012 at 13:04 UTC

Added attachment 166.jpg

Tixu Oct 01, 2012 at 11:08 UTC

Added attachment LogicRB.jpg

Tixu Oct 01, 2012 at 09:20 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Tixu Tixu Oct 02, 2012 at 17:50 UTC - 0 likes

    Thank you

    Yes I dont like the full copy too, but, i really dont see how to do that without having error in acelocale... if someone know...

    I have installed tortoise SVN, i will try to update frFR locales myself next time.

    Last edited Oct 02, 2012 by Tixu

    Wowcardioraid and WowCarto author

  • Avatar of cremor cremor Oct 02, 2012 at 15:49 UTC - 0 likes

    I've commited both files. But we should really find a way to insert the two crit entries without copying the whole table from enUS.

  • Avatar of Tixu Tixu Oct 02, 2012 at 13:25 UTC - 0 likes

    Thx, but, aceLocale is whining^^

    I have finally copied and simplified the statlist for frFR, so it's ok
    i have uploaded RB_frFR locales here too, then all main frFR fixes are up to date now.

    Thx!

    Last edited Oct 02, 2012 by Tixu
  • Avatar of cremor cremor Oct 02, 2012 at 12:37 UTC - 0 likes

    You can try it like that:

    table.insert(L["statList"], {pattern = "score de critique", id = CR_CRIT_MELEE})
    table.insert(L["statList"], {pattern = "score de coup critique", id = CR_CRIT_MELEE})
    

    I hope that works with an AceLocale table.

    About the file: Yeah, no problem, will commit it in about 2-3 hours.

  • Avatar of Tixu Tixu Oct 02, 2012 at 12:28 UTC - 0 likes

    Oh, I see, the statlist is defined in enUS locale.
    it's ok then I have fixed the issue.
    However, I have a lack of Lua knowledge here: is there a way to add some pattern to existing list?

    the list is defined like this:

    L["statList"] = {
    	{pattern = string.lower(SPELL_STAT1_NAME), id = SPELL_STAT1_NAME}, -- Strength
    	{pattern = string.lower(SPELL_STAT2_NAME), id = SPELL_STAT2_NAME}, -- Agility
    	{pattern = string.lower(SPELL_STAT3_NAME), id = SPELL_STAT3_NAME}, -- Stamina
    [...]
    }
    

    How can I add 2 new lines to the list in the frFR locales without having to copypaste the whole list from the enUS Locales?
    I need these lines:

    	{pattern = "score de critique", id = CR_CRIT_MELEE}, --Crit
    	{pattern = "score de coup critique", id = CR_CRIT_MELEE}, --Crit
    

    For the files:
    I dont have any svn tool installed at this time. If I continue to make update I will install such tool, for sure. For now, could you upload the file?

    thx!

    Last edited Oct 02, 2012 by Tixu
  • Avatar of cremor cremor Oct 02, 2012 at 11:40 UTC - 0 likes

    It's an open repository, you can commit the changes yourself. If you don't know how to use SVN I can commit it for you of course.

    About the RatingBuster crit issue: Since it works for deDE it must be a localization problem.
    As far as I understand the RatingBuster code, it first applies the patterns from L["numberPatterns"] to get the value and rating type text. Then it searches for the rating type text in the patterns that are defined in L["statList"]. The L["statList"] table is filled by GlobalString constants and again the ones with placeholders are processed first.
    I think this is again a similar problem that the captures in the patterns don't match the entries in L["statList"].

    Don't ask me why RatingBuster implements its own pattern matching ;-)

    Last edited Oct 02, 2012 by cremor
  • Avatar of Tixu Tixu Oct 02, 2012 at 10:45 UTC - 0 likes

    Hi
    I have made some change in the frFR locales (uploaded in attachment)
    Most of strings are now found through SinglePlusStatCheck or SingleEquipStatCheck.
    There is still a lot of cleanup to do, but at least this works for a lot of stats.

    however I didnt found how to fix that odd crit rating issue ...
    I didnt search yet where ratingbuster is reading strings, but that sounds very odd to me to have StatLogic and not using it...

    Last edited Oct 02, 2012 by Tixu
  • Avatar of cremor cremor Oct 01, 2012 at 15:56 UTC - 0 likes

    If it isn't needed any more than better remove it, yes. That will simplify the code.

    Btw, I've checked in the fix for the startup error. Maybe you'll want to update now instead of merge later ;-)

  • Avatar of Tixu Tixu Oct 01, 2012 at 15:49 UTC - 0 likes

    About the "[aA]ugmente de ?", I think it's probably better like this/

    The old SingleEquipStatCheck try to catch something between "augmente" and "de" because, sometimes ago the line was like
    "augmente la STAT de %d"
    today it's always
    "augmente de %d la STAT"

    I have checked some old stuff, and everything seems to follow this new rule. I guess they have unified all these labels

    (i will investigate about the chat issue, it's weird, I have Chatter too)

    Last edited Oct 01, 2012 by Tixu
  • Avatar of cremor cremor Oct 01, 2012 at 15:11 UTC - 0 likes
    Quote from JackTripper:

    But how was it working for you in deDE?

    It wasn't working before r164. That was the reason why I created ticket 38. Only english strings (or pre localized constant strings) were used for excluding between r145 and r164.

    Quote from Tixu:

    there is a trick to be able to see the whole starting log? i only have the last lines

    Works fine for me, but I'm using Chatter. Maybe the default Blizzard chat (or the Addon you are using) doesn't save that much lines.

    Quote from Tixu:

    this should probably be:
    newKey = gsub(newKey, "[aA]ugmente de ?", "")

    Ah, I didn't notice the "Augmente" in the SingleEquipStatCheck. Either remove that from the SingleEquipStatCheck pattern or remove it in ProcessNeutralStatIDLookupPlaceholders. But in the function you might need two gsub calls since there is something between "Augmente" and "de" that you don't want to remove (at least that's like the SingleEquipStatCheck pattern looks like).

    Btw, I'm at home now, I'll check in some changes shortly that fix the nil errors and remove some duplicated code.

Facts

Last updated
Oct 02, 2012
Reported
Oct 01, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees