LibStatLogic-1.2

37 - Spell damage localization constants used as strings

I couldn't test it since I don't use an english client, but I assume the following to lines in enUS.lua should use the actual constant values instead of the constant name, right?

["STAT_SPELLDAMAGE"] = {"SPELL_DMG", "HEAL",},
["ITEM_MOD_SPELL_POWER_SHORT"] = {"SPELL_DMG", "HEAL",}, --ITEM_MOD_SPELL_POWER_SHORT = "Spell Power";

User When Change
cremor Sep 29, 2012 at 10:44 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of JackTripper JackTripper Sep 29, 2012 at 12:28 UTC - 0 likes

    That seems like a good note, and i've made the change.

    But i cannot find anything that would actually use:

    • Spell Power
    • Spell Damage

    Everything's is Increases spell power by %s

    But yes, it makes no sense (as far as i can remember) to try to look for the string "ITEM_MOD_SPELL_POWER_SHORT". That definitely would never appear in-game

    Last edited Sep 29, 2012 by JackTripper
  • 1 comment

Facts

Reported
Sep 29, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees