LibStatLogic-1.2

36 - comma separators

What steps will reproduce the problem?
1.blizzard now uses comma separators in 1k+ numbers.
2.
3.

What is the expected output? What do you see instead?
LibStatLogic is not reading numbers with commas correctly, it thinks the stat is much smaller than it is.

What version of the product are you using?
r127

Do you have an error log of what happened?

Please provide any additional information below.

  • WoWScrnShot_091512_084447.jpg
  • WoWScrnShot_091512_084449.jpg
User When Change
MrGray Sep 15, 2012 at 15:55 UTC

Added attachment WoWScrnShot_091512_084449.jpg

MrGray Sep 15, 2012 at 15:55 UTC

Added attachment WoWScrnShot_091512_084447.jpg

MrGray Sep 15, 2012 at 15:55 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of JackTripper JackTripper Sep 15, 2012 at 22:02 UTC - 0 likes

    <<reply 954918="">>

    Is this an issue with Rating Buster?

    Whitetooth originally wrote LibStatLogic so he could write TankPoints.

    Then he created RatingBuster as graphical front-end around LibStatLogic. RatingBuster basically shows in tooltips what LibStatLogic tells it.

    And LibStatLogic has never had an API to expose "sometimes" attributes on items. Personally i wish it could take the average effect of an item:

    If Earthen Guardian Figuring adds 2500 dodge for 12 seconds, with a cooldown of 2 minutes, then it effectively adds 250 Dodge Rating. But a lot of items have hidden internal cooldowns, which needs some database to understand each item.

    Perhaps the Name of each item can start to add an effect itself:

    ["Figuring: Earthen Guardian"] = {"DODGE_RATING" = 250}
    

    But it starts to fall apart when you get into items, like Veil of Lies, which stack. You don't always be at full 10 stacks. So now you have to create some UI to configure how many stacks you expect to have up on any mob at any given time.

    Unless i decide that on average you'll have 4 stacks up:

    ["Veil of Lies'] = {"DODGE_RATING" = 18*4} --4 stacks of +18 Dodge Rating
    

    Which, now that i think about it, might be something i could do, a hard-coded database of every:

    Equip: ... has a chance to ...

    and

    Use: ...

    and decide what the effective stat is.

    But it is not this day. At the very least i'd only add them for items i use, because it's a huge database of items, most of which the internal cooldowns are not documented.

  • Avatar of MrGray MrGray Sep 15, 2012 at 19:00 UTC - 0 likes

    @JackTripper: Go

    i was more looking for a display of the rating to % conversion of the value once it procs, the trink states increases dodge by 2,290, LibStatLogic is attempting to convert the value but its only seeing the first digit of 2. hence the (+0.01%) its showing.

    Is this an issue with Rating Buster?

    Last edited Sep 15, 2012 by MrGray
  • Avatar of JackTripper JackTripper Sep 15, 2012 at 18:49 UTC - 0 likes

    LibStatLogic never has handled any "have a chance" effects - and they are specifically in an exclude list. Since there is no way to to know what the effect does, there's no way it can tell you about it.

    e.g.

    Your melee attacks have a chance to grant 1,149 dodge

    • what chance?
    • how often?
    • how long does it last?
    • what's the internal cooldown?

    Nor has LibStatLogic ever handled On use items, and they are specifically excluded. Since there's no way to know what the effect is, there's no way LibStatLogic can tell you about it, e.g.:

    Use: Increases your dodge by 2

    • what is it's internal cooldown?

    Believe me, i've looked into trying to make LibStatLogic understand my Earthen Guardian. But once i looked into it i realized that there's no way to know what stats the item provides.


    So, while it is true that i went through a lot of shit to get commas working

    Note: In Germany that same number shows as 1.149

    that's not why it's failing here.

  • 3 comments

Facts

Last updated
Sep 15, 2012
Reported
Sep 15, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees