LibStatLogic-1.2

33 - Talent API change

Line 6524 needs to be changed from GetPrimaryTalentTree  to GetSpecialization

User When Change
420Bunny Sep 04, 2012 at 16:05 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of 420Bunny 420Bunny Sep 05, 2012 at 14:43 UTC - 0 likes

    mkay.. I thought hitting the "Download" link would always pull the most recent file posted regardless of Alpha, Beta or Release status.. thanks for the heads up

  • Avatar of JackTripper JackTripper Sep 05, 2012 at 11:53 UTC - 0 likes

    <<reply 931623="">>

    Yeah, we're on revision 118. Revision 74 was from last April.

    There have been...well...44 updates since then. You need to instruct whatever you're using to download updates to use the latest (alpha) version of LibStatLogic.

    Only the project's manager, Whitetooth, can mark revisions as beta or release. And he's not updated anything in over a year. So you're going to have to accept updating LibStatLogic manually.

    Last edited Sep 05, 2012 by JackTripper
  • Avatar of 420Bunny 420Bunny Sep 05, 2012 at 08:59 UTC - 0 likes

    This is the error that alerted me to the issue in line 6524. Once I change from GetPrimaryTalentTree to GetSpecialization I no longer get this error message...

    1x LibStatLogic-1.2\LibStatLogic-1.2-74.lua:6524: attempt to call global "GetPrimaryTalentTree" (a nil value)

    LibStatLogic-1.2\LibStatLogic-1.2-74.lua:6524: in function <LibStatLogic-1.2\LibStatLogic-1.2.lua:6516>

    LibStatLogic-1.2\LibStatLogic-1.2-74.lua:6530: in function <LibStatLogic-1.2\LibStatLogic-1.2.lua:6527>

    Locals: self = StatLogicItemSetFrame {

    0 = <userdata>

    PLAYER_EQUIPMENT_CHANGED = <func> @..\..\LibStatLogic-1.2.lua:6536

    PLAYER_LOGIN = <func> @..\..\LibStatLogic-1.2.lua:6547

    PLAYER_TALENT_UPDATE = <func> @..\..\LibStatLogic-1.2.lua:6539

    }

    elapsed = 7.9090003967285

    GetTime = <func> =[C]:-1

    UpdateArmorSpecActive = <func> @..\..\LibStatLogic-1.2.lua:6516

  • Avatar of 420Bunny 420Bunny Sep 05, 2012 at 08:48 UTC - 0 likes

    The GetPrimaryTalentTree is still in the code in r74 in LibStatLogic-1.2.lua

    6516 local function UpdateArmorSpecActive()

    6517 ArmorSpecActive = nil

    6518 for _, slot in pairs(WatchInventoryID) do

    6519 local item = GetInventoryItemID('player', slot)

    6520 if not item then return end

    6521 if (select(7, GetItemInfo(item))) = playerArmorType then return end

    6522 end

    6523 all pass

    6524 ArmorSpecActive = GetPrimaryTalentTree() or 0

    6525 end

  • Avatar of JackTripper JackTripper Sep 04, 2012 at 17:44 UTC - 0 likes

    All instances of GetPrimaryTalentTree where converted to GetSpecialization a while ago.

    What revision are you using that you see this?

    Can you give some context around the source code where you're finding it (i cannot find it anywhere in LibStatLogic.lua).

  • 5 comments

Facts

Reported
Sep 04, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees