LibFail-1.0

4 - Clients of libfail should decide the thaddius threshold

What is the enhancement in mind? How should it look and feel?
If you're trying to go for the Thaddius achievement, then a single charge is a "failure".  The current implementation of libfail allows for 3 charge spell damage before firing the notifications.  It would be nice to put this decision/policy into the clients.  Let my code decide whether my raid mates have failed.

For now, I'm just modifying my copy to fire the callbacks at the first charge spell damage.

User When Change
sylvanaar May 02, 2009 at 16:13 UTC Changed status from New to Accepted
quantorsht Mar 11, 2009 at 01:48 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of sztanpet sztanpet Nov 26, 2009 at 08:41 UTC - 0 likes

    so we have some constants in libfail for these kind of things, but the problem is they are global
    so, ensidiafails right now customizes the built in thresholds ( libfail.THADDIUS_THRESHOLD = 8000 ) and that will affect every other mod using libfail too
    now that might be both a good and a bad thing
    the other solution might be to brake up the fail logic into different parts, one part that
    "detects the possible fail" with maybe some low caps on it for when a fail would trigger on every spellcast or something
    the higher up part would be near the fail event dispatch logic where you would check if its a fail or not, that could give us the flexibility needed, maybe even have a user callback to check if the target is a tank or not or something like that

  • Avatar of Rinu Rinu Jun 01, 2009 at 18:14 UTC - 0 likes

    You could implement a function to set the min count for a special fail event (eg. LibFail:SetMinCount("Fail_Thaddius_PolarityShift", 1) )

  • Avatar of sylvanaar sylvanaar Jun 01, 2009 at 15:05 UTC - 0 likes

    Thinking some more - there needs to be some consistency about what gets reported as a "fail" - otherwise people will wonder why they get different counts.

    Any thoughts on how to implement this?

  • Avatar of sylvanaar sylvanaar May 02, 2009 at 16:13 UTC - 0 likes

    you're right.

  • 4 comments

Facts

Last updated
Mar 30, 2012
Reported
Mar 11, 2009
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees