local fail = LibStub("LibFail-1.0")
local fail_events = fail:GetSupportedEvents()

local function onFail(event, who, failtype)
   -- Use the spellid as a default localized string for the fail event
   local spell = GetSpellInfo(fail:GetEventSpellId(event)) or ""

   -- Use the "failtype" argument to print appropriate messages based on it.
   local failmsg
   if failtype == fail.FAIL_TYPE_NOTMOVING then
       failmsg = "%s fails at moving (%s)"
   end

   print( failmsg:format(who, spell) )
end
for _, event in ipairs(fail_events) do
	fail.RegisterCallback("SampleAddon", event, onFail)
end

You must login to post a comment. Don't have an account? Register to get one!

• 

  • #20

  mysticalos Fri, 30 Oct 2009 05:06:48

  Icecrown is shaping up ;)

• 

  • #17

  sztanpet Fri, 23 Oct 2009 10:22:23

  are you using the appropriate repo url (the development url not the public url), have you set your svn password or your ssh public key, whichever is more appropriate, etc

• 

  • #16

  mysticalos Fri, 23 Oct 2009 09:14:11

  I know anyone with a curse account and svn and good code base could add their own fails in past, it even says above "This is an open repository. Feel free to add to it, and make fixes yourself"

  Has this changed? cause i had tried fixing a the missing spelids and adding malygos arcanebreath myself but i got permission denied after i had made all the changes and tried to commit :(. I helped with all the ony fails and like half the toc fails for ensidiafails, fixed all the spellids on ones maat did too :P I think he's used to waking up to new tickets from me every couple days or so. One bad raid night, or bad pug on an alt and I have ideas for new fails hehe.

  The change to breath I only suggested cause i figured there was a reason maat didn't use spellid method. It was used at first but it was changed when during last code cleanup I'm assuming for some reason. Wow devs were pretty bad coders back then anyways, 93 spell ids, and 6 (maybe 7 or 8 i don't remember count) scripted events determining which set is used based on her location was a pretty ugly.

  Last edited on 23 Oct 2009 by mysticalos
• 

  • #15

  sztanpet Fri, 23 Oct 2009 08:12:29

  IRC(#wowace @ freenode) is a good place to talk about the addon, looking at comments or tickets is very sporadic, you have a bigger chance of alerting the devs on there, freenode has a nice webchat too making things much simplre, but if you do come around please remember that we are not always present so you might not get a response instantly

  also, where is auriaya voidzone listed twice? edit: yea i see it now, its on the main page, fixed

  edit2: regarding the onyxia deep breath fail, yes that could be nicer way to do it, but the existing method being a resource hog is not really relevant, this is not the thing that will slow your addons down

  Last edited on 23 Oct 2009 by sztanpet
• 

  • #14

  mysticalos Fri, 23 Oct 2009 05:37:28

  tried to submit changes to repository but it's no longer open? :\

  Was gonna fix the long standing ticket #1. :P

      -- Malygos - Arcane Breath
      if (spellId == 56272 or spellId == 60072) and is_playerevent then -- not a fail for tanks, but we dont care about that here
          self:FailEvent("Fail_Malygos_Breath", destName, self.FAIL_TYPE_WRONGPLACE)
  
          return
      end
  

  This is of course assuming the event is registered in all the appropriate areas, locals, fail_events,zones_with_fails,event_spellids,fails_where_tanks_dont_fail

  Btw, should really look at tickets more often. Light/gravity bomb is STILL broken on 10 man and bug was reported last June. the 10 man spellids for light/gravity bomb are missing.

  searing light missing ID: http://www.wowhead.com/?spell=63023

  Gravity Bomb missing id: http://www.wowhead.com/?spell=63025

  Last edited on 23 Oct 2009 by mysticalos
• 

  • #13

  mysticalos Thu, 22 Oct 2009 21:51:23

  http://www.wowhead.com/?spell=68868

  is used by onyxia ONLY, there is no reason to use if self:GetMobId(sourceGUID) = 10184 then return end

  The function is used on add cleave because that spellid is shared, with 104 creatures.

  also you listed void zone twice for auriaya ;)

  The deep breath method is crued and probably a resource hog for 2432534635r spellids. That's what I used at first when i originally gave fail to maat. But he made up a new method that used spellname and spellzone instead I think. I'd have to look at code again to see what he used. But something like "if spellname="breath" and zone="onyxia's Lair" :) Plus it ruled out posiblity of any missing spellids causing a missed fail.

  Last edited on 23 Oct 2009 by mysticalos
• 

  • #12

  wxx011 Sun, 14 Jun 2009 02:44:11

  sorry,when I into Mimiron Stage 2,I got this error message

  LibFail-1.0-65 (Skada):320: Usage: UnitDebuff(\"unit\", [index] or [\"name\", \"rank\"][, \"filter\"])\nLibFail-1.0-65 (Skada):320: in function <...terface
  AddOns
  Skada
  lib
  LibFail-1.0
  LibFail-1.0.lua:307>\nLibFail-1.0-65 (Skada):250: in function <...terface
  AddOns
  Skada
  lib
  LibFail-1.0
  LibFail-1.0.lua:244>\n\n -

• 

  • #11

  sylvanaar Mon, 01 Jun 2009 14:32:47

  We have a special channel for fails, just like we do for damage meters

• 

  • #10

  mysticalos Sun, 31 May 2009 07:05:30

  Now just add that hodir biting cold, the code should be in ensidiafail to look at.

• 

  • #9

  mysticalos Sat, 30 May 2009 18:29:59

  9 times out of 10, it's not the tank being hit by it. so it's a good fail to have. a raid can safely ignore a tank if they choose to but it's still good to see who else is standing in it. I don't use failboat anyways i use recountfail so libfail is only sending it's data to recount for after battle tracking not in battle spamming. :)