LibDogTag-Unit-3.0

12 - Reputation and MaxReputation does not find faction by name

What steps will reproduce the problem?
1. Reputation(Faction(unit=Target))
2. MaxReputation(Faction(unit=Target))
3.

What is the expected output? What do you see instead?
Expect to see reputation value. No value returned as faction was not found based on code.

What version of the product are you using?
r181

Do you have an error log of what happened?
no

Please provide any additional information below.

Seems like a variable name was assumed to be "n" but it should be "name".

On line 20, please change "if faction == n then" to "if faction == name then"
On line 44, please change "if faction == n then" to "if faction == name then"

I made these two changes locally and it works.

For fun, this is the dogtag text I have come to enjoy for my reputation text which allows me to view the reputation for my target NPC before I hit repair on my alts.
It is not optimized but gets me what I want to see at a glance.

[if IsMouseOver then
    ReputationReaction ':' ReputationName
elseif IsFriend(unit=Target) and (Guid(unit=Target) ~= Guid(unit="player")) then
    ReputationReaction(Faction(unit=Target)) ':' Faction(unit=Target) ':' MissingReputation(Faction(unit=Target))
else
    [if ReputationName then
        MissingReputation ' ' PercentReputation:Percent:Paren
    end]
end]

User When Change
cahannah Wed, 25 Mar 2009 06:41:46 Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated on
25 Mar 2009
Reported on
25 Mar 2009
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees