LibBackdrop-1.0

1 - EnhanceBackdrop does not remove previously set backdrop

Shouldn't EnhanceBackdrop remove the frame's existing backdrop? The EnableEnhancements method does this, but it doesn't look like it's intended that I should need to call EnableEnhancements immediately after EnhanceBackdrop. If the frame's existing backdrop isn't removed, then any backdrop set after enhancement isn't visible (unless the existing backdrop was partially or completely transparent), so it seems like it should just be removed automatically. You could even reapply the previous backdrop after enhancement using the new methods if you wanted, though it seems like anyone using the lib probably intends to set a new backdrop anyway.

Edit:
If you're short on time, I can commit the change myself, just let me know.

User When Change
Phanx Jan 14, 2014 at 12:57 UTC Changed description:
  Shouldn't `EnhanceBackdrop` remove the frame's existing backdrop? The `EnableEnhancements` method does this, but it doesn't look like it's intended that I should need to call `EnableEnhancements` immediately after `EnhanceBackdrop`. If the frame's existing backdrop isn't removed, then any backdrop set after enhancement isn't visible (unless the existing backdrop was partially or completely transparent), so it seems like it should just be removed automatically. You could even reapply the previous backdrop after enhancement using the new methods if you wanted, though it seems like anyone using the lib probably intends to set a new backdrop anyway.
+
+ *Edit:*
+ If you're short on time, I can commit the change myself, just let me know.
Phanx Jan 14, 2014 at 11:23 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Phanx Phanx Jan 30, 2014 at 19:52 UTC - 0 likes

    Committed.

  • Avatar of kagaro kagaro Jan 20, 2014 at 21:12 UTC - 0 likes

    go for it

  • 2 comments

Facts

Last updated
Jan 14, 2014
Reported
Jan 14, 2014
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0
Component
Library

Reported by

Possible assignees