WowAce

There's a typo in the source code. `IsRowVisible()` is actually exposed as `RowIsVisible()` via the API. So if anyone needs that function, just type the alternative name. I'm trying to use that function to check if a database row I'm modifying is visible and if so, I call `Refresh()` to re-draw the visible rows.

Edit: Nevermind. It doesn't matter. The code in `IsRowVisible()` in this library is **completely** bugged. It is comparing the real row number (of something in your data array) against the virtual row `offset` number of the FauxScrollingFrame. So, let's say you've scrolled down a bit and the 1st row of your FauxScrollingFrame is at `offset` 21 and is displaying data[2]. In this case, the `IsRowVisible()` function would check if `realrow > offset` and fails completely to find the row. It's literally completely broken and there is nothing salvageable about the current code.

To make this broken library function work, it would have to be totally rewritten to have a loop which checks all positions in `.filtered[]` (the array of "sorted offsets in the order to be displayed"), starting from scrolltable's `.offset` all the way to `.offset + .displayRows`, and checks if any of those contain the number of the real row you're looking for.

If anyone wants to to code a fix for themselves, keep in mind that `.offset` starts at 0 whereas `.filtered`'s array entries count up from 1...

Edit 2: Alright, I've fixed and quadruple-checked things to make sure it's now perfect. Here's the bugfix for `IsRowVisible()`. I'll also be posting this on the project front-page/comments section.

diff -ru a/Core.lua b/Core.lua
--- a/Core.lua	2018-10-29 19:34:26.000000000 +0100
+++ b/Core.lua	2018-10-29 19:33:57.000000000 +0100
@@ -592,9 +592,16 @@
 	-- @name IsRowVisible
 	-- @description Checks if a row is currently being shown
 	-- @usage st:IsRowVisible(realrow)
-	-- @thanks sapu94
 	local function IsRowVisible(self, realrow)
-		return (realrow > self.offset and realrow <= (self.displayRows + self.offset))
+		-- Scan through all on-screen rows, checking their real data row numbers for a match.
+		local firstVisibleIdx = 1 + (self.offset or 0);
+		local lastVisibleIdx = (firstVisibleIdx + self.displayRows) - 1;
+		for i=firstVisibleIdx,lastVisibleIdx do
+			if self.filtered[i] == realrow and realrow ~= nil then
+				return true;
+			end
+		end
+		return false;
 	end
 	
 	function ScrollingTable:CreateST(cols, numRows, rowHeight, highlight, parent)
@@ -629,7 +636,7 @@
 		st.GetCell = GetCell;
 		st.GetRow = GetRow;
 		st.DoCellUpdate = DoCellUpdate;
-		st.RowIsVisible = IsRowVisible;
+		st.IsRowVisible = IsRowVisible;
 		
 		st.SetFilter = SetFilter;
 		st.DoFilter = DoFilter;