Ji-Kun Nest Announcer

4 - Spare is whispered even while dead

The code that uses the Spare dps doesn't bother checking if the lucky recipient is actually alive. It should test not UnitIsDead(self.db.profile.SPARE1) and not UnitIsGhost(self.db.profile.SPARE1) before adding the spare to the group.

User When Change
BlueWarlord Aug 03, 2013 at 20:31 UTC
eridius Aug 01, 2013 at 07:19 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of BlueWarlord BlueWarlord Aug 03, 2013 at 20:30 UTC - 0 likes

    Actually, I thought adding this check when I implemented it, but decided against it.The spare is only whispered when there is a shortage in one of the groups (e.g. someone died), the idea would be that a dead spare could still call out on Vent/TS for someone to help out. Does this make sense?

    Last edited Aug 03, 2013 by BlueWarlord
  • 1 comment

Facts

Last updated
Aug 03, 2013
Reported
Aug 01, 2013
Status
Waiting - Waiting for more information.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees