Grid

680 - Add clamp insets to match frame spacing

Grid version:

5.2.0.1573

WoW version and region/language:

5.2 enGB

Steps to reproduce the problem:

  1. Set layout spacing to 0 and padding to 2 (for example)
  2. BlizzardTooltip as background texture is now smaller (by ~2 px on each side) than the space the frames occupy

What you expected to happen:

Background should be 0 px or 1 px bigger than the frames to give the impression that the frames are "in" it (i.e. a bounding box).

Name Description Size MD5
Grid.lua Grid SavedVariables 251.6 KiB 14155af51a90...
  • grid_5.2.jpg
    Screenshot
User When Change
Phanx Mar 21, 2013 at 20:38 UTC
Phanx Mar 21, 2013 at 20:38 UTC
Phanx Mar 13, 2013 at 21:34 UTC
Phanx Mar 07, 2013 at 03:03 UTC
Phanx Mar 07, 2013 at 03:01 UTC Changed description:
  #### **WoW version and region/language:**
  5.2 enGB
-
- #### **Character race, class, spec, and level:**
- Draenei, Paladin, Retribution/Protection, 90
-
  #### **Steps to reproduce the problem:**
----------------------------------------
  #### **What you expected to happen:**
  Background should be 0 px or 1 px bigger than the frames to give the impression that the frames are "in" it (i.e. a bounding box).
-
-
- #### **What actually happened:**
- 3. See screenshot
-
-
- #### **Does the problem still happen when all other addons — including all Grid plugins — are disabled?**
- Not tested
-
-
- #### **Does the problem still happen after you switch to a new profile in Grid with default settings, log out, and log back in?**
- Not tested, settings attached; I don't actually know that I'm using any specific profile, so I hope "default" is the right answer... :\
-
-
- #### **Exact text of the first related error message, if any:**
- No errors
-
-
- #### **Screenshot, if the problem is graphical:**
- Attached
-
-
- #### **Anything else you think might be helpful:**
- Forum post: #### **Grid version:**
- 5.2.0.1573
-
- #### **WoW version and region/language:**
- 5.2 enGB
-
- #### **Character race, class, spec, and level:**
- Draenei, Paladin, Retribution/Protection, 90
-
-
- #### **Steps to reproduce the problem:**
-
- 1. Set layout spacing to 0 and padding to 2 (for example)
- 2. BlizzardTooltip as background texture is now smaller (by ~2 px on each side) than the space the frames occupy
-
- #### **What you expected to happen:**
- Background should be 0 px or 1 px bigger than the frames to give the impression that the frames are "in" it (i.e. a bounding box).
-
-
- #### **What actually happened:**
- 3. See screenshot
-
-
- #### **Does the problem still happen when all other addons — including all Grid plugins — are disabled?**
- Not tested
-
-
- #### **Does the problem still happen after you switch to a new profile in Grid with default settings, log out, and log back in?**
- Not tested, settings attached; I don't actually know that I'm using any specific profile, so I hope "default" is the right answer... :\
-
-
- #### **Exact text of the first related error message, if any:**
- No errors
-
-
- #### **Screenshot, if the problem is graphical:**
- Attached
-
-
- #### **Anything else you think might be helpful:**
- Forum post: http://forums.wowace.com/showpost.php?p=325164&postcount=399
-
-
- Thanks! :-)
-
-
- Thanks! :-)
Phanx Mar 07, 2013 at 03:00 UTC
gnarfoz Mar 06, 2013 at 23:59 UTC

Added attachment grid_5.2.jpg

gnarfoz Mar 06, 2013 at 23:59 UTC

Added attachment Grid.lua

gnarfoz Mar 06, 2013 at 23:58 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Phanx Phanx Mar 21, 2013 at 20:38 UTC - 0 likes

    I've increased the clamp insets and actual frame width by 4 in each direction to compensate for the backdrop insets. Since nobody has reported any issues, I'm calling this good.

    If you are still seeing an issue with 5.2.0.1578-beta or newer, please submit a new ticket as I likely won't see updates to this closed ticket.

  • Avatar of Phanx Phanx Mar 13, 2013 at 21:34 UTC - 0 likes

    Please try 5.2.0.1578-beta and let me know if the clamp insets are big enough for you.

  • Avatar of Phanx Phanx Mar 07, 2013 at 03:16 UTC - 0 likes

    Fix committed. I'll tag a release later tonight after I have time to actually test it.

  • Avatar of Phanx Phanx Mar 07, 2013 at 03:03 UTC - 0 likes

    The background frame is technically not smaller, but the background texture has insets to accomodate a border texture, since both the background and border textures have to fit inside the actual frame boundaries. Since you're not using a border texture, there's nothing filling in the inset area.

    To address this, I'll be adding clamp insets to the frame that match the current Frame Spacing setting, so if you have 10px of spacing, you'll be able to move any edge of the frame up to 10px outside the screen.

  • 4 comments

Facts

Last updated
Mar 21, 2013
Reported
Mar 06, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees