Grid

602 - Add Resurrection status

Task:

Add a basic Resurrection status module using the resurrection-related API added in Patch 4.2.

Current Status:

Drycoded. Needs more testing.

Problems:

  • INCOMING_RESURRECT_CHANGED fires as soon as the resurrection spell cast ends, not when the resurrection expires or is accepted.
  • UnitHasIncomingResurrection returns false after the cast ends, even if the resurrection has not expired or been accepted yet.

Solutions:

  • When INCOMING_RESURRECT_CHANGED fires and UnitHasIncomingResurrection returns true, SendStatusGained, and add the unit to a "hasIncomingResurrection" table.
  • When INCOMING_RESURRECT_CHANGED fires and UnitHasIncomingResurrection returns false, register the UNIT_HEALTH event and start a timer.
  • If UNIT_HEALTH fires for the unit, check if the unit is no longer dead, SendStatusLost because the resurrection was accepted.
  • If the timer expires, SendStatusLost because the resurrection expired.

Other Issues:

  • The resurrection API does not consider soulstones. Possibly good for a separate module with aura tracking (Soulstone) and cooldown tracking (Reincarnation)?
User When Change
Phanx Jun 19, 2012 at 23:56 UTC
Phanx Apr 22, 2012 at 02:00 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Phanx Phanx Jun 19, 2012 at 23:55 UTC - 0 likes

    I've tagged a beta with the Resurrection status to get a broader test audience. Marking this ticket as resolved; if you find any issues, please post in the relevant open ticket, or post a new ticket if none exists. Thanks.

  • Avatar of jlam jlam Jun 11, 2012 at 13:52 UTC - 0 likes

    My testing in LFR and in a 10-man raid showed no obvious errors, especially with the battle rez scenario. It showed the pending battle rez when the dead toon was instructed to hold off on accepting until it was safe to accept the rez.

  • Avatar of Phanx Phanx Jun 08, 2012 at 00:59 UTC - 0 likes

    Good catches. Fixed in r1479.

    Raid testing will be welcome, especially situations where multiple people are casting a res on the same target.

  • Avatar of jlam jlam Jun 07, 2012 at 19:52 UTC - 0 likes

    Via code-inspection:

    • Line 142: in the UpdateUnit() method, GetTime() is called again instead of using the now value from line 131.
    • Line 189: in the COMBAT_LOG_EVENT_UNFILTERED() method, "received" is misspelled in the debug message.

    Will test it out in a raid as soon as I can (probably this weekend).

  • Avatar of Phanx Phanx Jun 07, 2012 at 12:43 UTC - 0 likes

    Experimental status module added in r1478.

    If you find any problems with the new status:

    1. Disable all other addons, including Grid plugins. If the problem doesn't happen, enable your other addons one at a time until the problem comes back. Then, disable everything except Grid and the last addon you enabled. If the problem still happens with just these two, post the name of the other addon, and a link to where I can download it.
    2. Install BugSack if you don't already have it, and look for errors mentioning Grid. If there are any, copy and paste them. Do not copy or paste the lists of local variables that appears after the error message. I really only want the first 1-2 lines of the error message.
    3. Enable debugging for the GridStatusResurrect module in the Grid options window. Take a screenshot of the messages that appear in your chat frame the next time someone in your group resurrects someone else in your group, and post the screenshot along with a detailed description of your group (party, raid, in an instance, in a battleground, 3 players, 30 players, 1 res casting, 10 rezzes casting on the same person, etc.) and what problem is.
    Last edited Jun 07, 2012 by Phanx
  • 5 comments

Facts

Last updated
Jun 19, 2012
Reported
Apr 22, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees