Grid

577 - New healing bar color problem

*** IMPORTANT: If you are using an alpha version of Grid, please do not post here. Alpha zips are generated from the current development code, and are never guaranteed to work. Roll back to the latest release version if you're having a problem with an alpha version. ***

== What version of Grid are you using? (Tickets that do not include the actual version number will be ignored.)
r1450 (yes, I'm aware it's an alpha but I feel this needs to be reported since I'm going to be forced to upgrade eventually by the 4.3 changes)

== What version and language of WoW are you using?
enUS North American client

== Does the problem still happen when you disable all addons (including Grid plugins) except for Grid?
Yes

== What is the problem? What were you doing when it happened? What steps can we follow to reproduce it?
After the addition of the healing bar color option and with the new option UNchecked (i.e. the old way), when I cast a heal the bar darkens slightly from the default and when the heal completes the bar is lighter than the default. Sometimes these changes just flash over the bars, sometimes they stick until the next heal. The problem only seems to start happening on a given bar with the first effective incoming heal.

== If there is an error message related to the problem, copy and paste it here:
There are no errors

== If the problem is graphical, take a screenshot and either attach it to your ticket, or upload it somewhere and include the URL here:
Default color after a /reloadui: http://www.mizore.org/sandbox/default.png
Color while casting any time after the first effective heal (too dark): http://www.mizore.org/sandbox/casting.png
Color after the prior cast has finished (too light): http://www.mizore.org/sandbox/after.png

== Please provide any additional information below.
All this happened with just Grid enabled even though I took the screenshots with other addons running. This is using class colored health bars/healing bars and invert bar color UNchecked.

User When Change
Phanx Apr 22, 2012 at 05:52 UTC Changed status from Declined to Fixed
Phanx Mar 31, 2012 at 08:27 UTC Changed status from Accepted to Declined
Phanx Mar 05, 2012 at 22:17 UTC Changed priority from Medium to Low
Phanx Dec 13, 2011 at 00:16 UTC Changed priority from High to Medium
Phanx Nov 17, 2011 at 03:50 UTC Changed status from New to Accepted

Changed priority from Medium to High
Riory Oct 28, 2011 at 05:34 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Phanx Phanx Apr 22, 2012 at 05:52 UTC - 0 likes

    Fixed in r1465.

    The "Healing bar uses status color" option is once again available, and working correctly with normal and inverted bars.

  • Avatar of Phanx Phanx Mar 31, 2012 at 08:27 UTC - 0 likes

    Tired of this jumping to the top of the ticket list when someone votes on it, and since Curse does not give an option to sort tickets by the date of the last ACTUAL update, or to turn off voting, I'm marking it as Declined for now.

  • Avatar of Phanx Phanx Dec 13, 2011 at 00:16 UTC - 0 likes

    I've removed the option for now, so I can tag a new release version. I'll re-add it later when I have time to properly test and debug it.

  • Avatar of Riory Riory Oct 28, 2011 at 06:06 UTC - 0 likes

    So before that change was added the SetHealingBar function looked like

    function GridFrame.prototype:SetHealingBar(value, max)
    	if max == nil then
    		max = 100
    	end
    
    	local perc = value / max
    	self.HealingBar:SetValue(perc * 100)
    
    	local coord = (perc > 0 and perc <= 1) and perc or 1
    	if GridFrame.db.profile.orientation == "VERTICAL" then
    		self.Bar:GetStatusBarTexture():SetTexCoord(0, 1, 1 - coord, 1)
    	else
    		self.Bar:GetStatusBarTexture():SetTexCoord(0, coord, 0, 1)
    	end
    
    	self:UpdateHealingBarColor()
    end
    

    The changed removed that UpdateHealingBarColor() function and the call to it in that SetHealingBar function. In exchange a new function, SetHealingBarColor(r,g,b,a), was added that includes the old code from UpdateHealingBarColor() as well as a new clause for setting the new colors. But no call to this new function is made in the new SetHealingBar function. A janky fix to my particular problem is to add a call to the new SetHealingBarColor (with no arguments because I don't want a custom color for the healing bar) function to the end of the SetHealingBar() function:

    function GridFrame.prototype:SetHealingBar(value, max)
    	if max == nil then
    		max = 100
    	end
    
    	local perc = value / max
    	self.HealingBar:SetValue(perc * 100)
    
    	local coord = (perc > 0 and perc <= 1) and perc or 1
    	if GridFrame.db.profile.orientation == "VERTICAL" then
    		self.Bar:GetStatusBarTexture():SetTexCoord(0, 1, 1 - coord, 1)
    	else
    		self.Bar:GetStatusBarTexture():SetTexCoord(0, coord, 0, 1)
    	end
    
    	self:SetHealingBarColor()
    end
    

    This might not work if you want to use a custom healing bar color, but like I said, it fixes my problem.

  • 4 comments

Facts

Last updated
Apr 22, 2012
Reported
Oct 28, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Low - Might slip to a later milestone.
Votes
2

Reported by

Possible assignees