Grid

439 - config window broken (layout)

What version of Grid are you using?

 - r1392

What version and language of WoW are you using?

 - current live version (enGB client)

What were you doing when the problem occured?

 - opened the config window of grid

What happened? What did you expect to happen instead?

 - the "frame" tab was sort of distorted. it was not showing everything it should,
   because the scroll bar on the right seemed to be connected to a sub-portion
   of the options instead of the whole window.

   i can however stretch the window across the whole screen and all is shown
   perfectly well with no elements hidden or broken/not usable.

   i will attach a screen to the ticket.

Do you have an error log of what happened?

 - no lua-errors were thrown

Does the problem still happen when you disable all addons (including Grid plugins) except for Grid?

 - the problem disappears if i disable "GridIndicatorCornerIcons" and "GridIndicatorSideIcons"
   made by kunda. because i am not very good at coding i cannot tell if the culprit is on grids
   or on the plugins side. all i know is that disabling gets rid of the problems but as far as I can
   imagine the plugins hook into the option window and something goes wrong there.

  • scrollbar_broken.jpg
    the broken elements are marked ...
User When Change
Phanx Nov 09, 2010 at 06:17 UTC Changed status from New to Declined
Anurion Nov 08, 2010 at 11:26 UTC

Added attachment scrollbar_broken.jpg

Anurion Nov 08, 2010 at 11:25 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Phanx Phanx Dec 14, 2010 at 04:49 UTC - 0 likes

    How do users configure their plugins atm with the configuration options off the screen?

    Stop using outdated plugins. No official support for plugins is provided or guaranteed at all. You should especially not expect an outdated plugin to be completely usable or functional.

    Last edited Dec 14, 2010 by Phanx
  • Avatar of stassart stassart Dec 13, 2010 at 14:06 UTC - 0 likes

    Nm, I figured it out.

    Just change:

    type = "group",

    to:

    type = "group", inline = true,

    In the plugin

  • Avatar of stassart stassart Dec 13, 2010 at 13:59 UTC - 0 likes

    How do users configure their plugins atm with the configuration options off the screen?

  • Avatar of Phanx Phanx Nov 09, 2010 at 06:17 UTC - 0 likes

    The problem is partly with the plugin(s), and partly with the AceConfigDialog-3.0 library that generates the actual configuration window from a data table Grid creates (and plugins add to). AceConfig organizes options based on the concept of "groups". Previously, Grid's data table didn't provide any "hints" on how AceConfig should render its options, so AceConfig used the default "tree view" layout. I didn't think this layout was very user-friendly (navigating through the options required clicking tiny buttons to expand nested list menus, and clicking on many list menu entries showed a blank panel), so I'm working on changing it.

    Part of this change involves "hinting" that some groups should be shown "inline". You can see this in the "Frame" section; the "Bar" options are a group, but they're shown in the same panel, just with a box drawn around them to show that they're together. The problem is that not all plugins are providing the same hint (because they haven't been updated yet), and AceConfig doesn't really know how to render sections where some groups are inline, and some groups aren't inline, at the same level.

    Status plugins and layout plugins don't break the menu because they're not working with the part of Grid's options table that now tells AceConfig to render subgroups inline.

    If you need to change a setting related to a non-status, non-layout plugin, you'll need to either (a) wait until the plugin is updated, or (b) temporarily revert to an older version of Grid.

    Either way, it's not actually a bug in Grid, so I'm going to close the ticket.

  • Avatar of Mang Mang Nov 08, 2010 at 18:48 UTC - 0 likes

    Hi,

    The config window is very better on r1392 and r1393, but i have the same problem as Anurion, and if i disable some plugins, the problem disappear.

    List of tested plugins :

    • GridUnitMenu: ok
    • Grid_QuickHealth: ok
    • GridConfigIcons: break
    • GridCooldownText: break
    • GridCustomLayouts: ok
    • GridIndicatorCornerIcons: break
    • GridIndicatorCornerPlus: break
    • GridIndicatorCornerText: break
    • GridIndicatorSideIcons: break
    • GridIndicatorSidePlus: break
    • GridIndicatorSideText: break
    • GridIndicatorText3: break
    • GridManaBars: break
    • GridStatusHealingReduced: ok
    • GridStatusHostileUnit: ok
    • GridStatusAFK: ok
    • GridStatusDungeonRole: ok
    • GridStatusHots: ok
    • GridStatusLineOfSight: ok (personal version based on r1392)
    • GridStatusRaidDebuff: ok
    • GridStatusRaidIcons: ok
    • GridStatusRes: ok
    • GridStatusRole: ok
    • GridStatusSanity: ok
    • GridTooltip: ok

    I'm only a amateur coder, however my modified GridStatusLineOfSight don't break the config window, and you have writen No plugin changes are required on r1392 change log.

    So i think that the problem is with the code of listed addons that break the config window.

    Thanks for yor great addon, and sorry for my bad english.

  • 5 comments

Facts

Last updated
Nov 09, 2010
Reported
Nov 08, 2010
Status
Declined - We decided not to take action on this ticket.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees