421 - Add duration and stack count status text/color
For each aura tracked by GridStatusAuras, there are two new suboptions to manage settings for a duration status and a stack count status. For each new status, one can set a low color, middle color and high color, with a low threshold and a high threshold to denote the boundaries between when color changes happen.
If any of the aura statuses map duration onto either text or color, then a repeating timer is set up to refresh the Grid units based on a settable refresh interval. If duration isn't used for any aura that's currently active on Grid units, then the timer is removed. Each aura status has a refresh interval setting, and the smallest interval used by active auras on the Grid units is chosen for the repeating timer.
The main purpose of the changes is to allow tracking of HoT and debuff timers using Grid text indicators. For most simple HoTs, just mapping duration to the text status is sufficient, but something like Lifebloom can have the duration mapped to text and stack count mapped to color to display both pieces of information on the same indicator. For buffs with charges, e.g. shaman shields, the stack count can be mapped to both the text and color statuses so that a warning color is used when a minimum threshold, e.g. 1 charge remaining, is reached. An example debuff might be Instability in the Sindragosa fight, where the text might show duration while the color could show stack counts with green for low counts, yellow for moderate counts, and red for dangerous counts of the debuff.
| Name | Description | Size | MD5 |
|---|---|---|---|
| GridStatusAuras.lua.diff | Patch v1 | 23.7 KiB | 878261b0dc96... |
| GridStatusAuras.lua.diff | Patch v2 | 22.6 KiB | b731ac4b706a... |
| GridStatusAuras.lua.diff | Patch v3 | 21.3 KiB | 775f23ee8608... |
| GridStatusAuras.lua-v4.diff | Patch v4 | 23.5 KiB | 004b2ed92bb3... |
| GridStatusAuras.lua-v5.diff | Patch v5 | 27.1 KiB | 57a7bfcacea4... |
| GridStatusAuras.lua.diff | Patch v6 | 28.2 KiB | 2c4f404a2d2d... |
| GridStatusAuras.lua | Patch v6 applied to r1443 | 39.4 KiB | 142ad21894e1... |
| User | When | Change |
|---|---|---|
| Phanx | Oct 16, 2011 at 07:36 UTC | Changed status from Started to Fixed |
| Phanx | Oct 14, 2011 at 00:18 UTC | Changed status from Accepted to Started |
| Phanx | Oct 13, 2011 at 23:47 UTC | Changed status from New to Accepted |
| jlam | Sep 23, 2011 at 19:51 UTC | Added attachment GridStatusAuras.lua |
| jlam | Sep 23, 2011 at 19:51 UTC | Added attachment GridStatusAuras.lua.diff |
| jlam | Sep 23, 2011 at 19:51 UTC | Deleted attachment GridStatusAuras.lua: Missing a change. Re-uploading correct file. |
| jlam | Sep 23, 2011 at 19:50 UTC | Deleted attachment GridStatusAuras.lua.diff: Missing a change. Re-uploading correct file. |
| jlam | Aug 19, 2011 at 19:36 UTC | Added attachment GridStatusAuras.lua |
| jlam | Aug 19, 2011 at 19:35 UTC | Added attachment GridStatusAuras.lua.diff |
| jlam | Nov 20, 2010 at 01:37 UTC | Added attachment GridStatusAuras.lua-v5.diff |
| jlam | Nov 20, 2010 at 01:37 UTC | Deleted attachment GridStatusAuras.lua-v5.diff: Wrong patch |
| jlam | Nov 20, 2010 at 01:24 UTC | Added attachment DurationColors.jpg |
| jlam | Nov 20, 2010 at 01:24 UTC | Added attachment DurationStatus.jpg |
| jlam | Nov 20, 2010 at 01:20 UTC | Added attachment GridStatusAuras.lua-v5.diff |
| jlam | Nov 16, 2010 at 05:12 UTC | Added attachment GridStatusAuras.lua-v4.diff |
| jlam | Nov 16, 2010 at 01:36 UTC | Deleted attachment GridStatusAuras.lua-v4.diff: Premature upload |
| jlam | Nov 16, 2010 at 01:34 UTC | Added attachment GridStatusAuras.lua-v4.diff |
| jlam | Nov 09, 2010 at 06:20 UTC | Added attachment GridStatusAuras.lua.diff |
| Greltok | Oct 26, 2010 at 18:23 UTC | Changed assigned to from Pastamancer to Phanx |
| jlam | Oct 26, 2010 at 02:05 UTC | Changed description:+ plain$For each aura tracked by GridStatusAuras, there are two new suboptions to manage settings for a duration status and a stack count status. For each new status, one can set a low color, middle color and high color, with a low threshold and a high threshold to denote the boundaries between when color changes happen. + + If any of the aura statuses map duration onto either text or color, then a repeating timer is set up to refresh the Grid units based on a settable refresh interval. If duration isn't used for any aura that's currently active on Grid units, then the timer is removed. Each aura status has a refresh interval setting, and the smallest interval used by active auras on the Grid units is chosen for the repeating timer. + + The main purpose of the changes is to allow tracking of HoT and debuff timers using Grid text indicators. For most simple HoTs, just mapping duration to the text status is sufficient, but something like Lifebloom can have the duration mapped to text and stack count mapped to color to display both pieces of information on the same indicator. For buffs with charges, e.g. shaman shields, the stack count can be mapped to both the text and color statuses so that a warning color is used when a minimum threshold, e.g. 1 charge remaining, is reached. An example debuff might be Instability in the Sindragosa fight, where the text might show duration while the color could show stack counts with green for low counts, yellow for moderate counts, and red for dangerous counts of the debuff. |
| jlam | Oct 26, 2010 at 02:03 UTC | Added attachment GridStatusAuras.lua.diff |
| jlam | Oct 25, 2010 at 08:13 UTC | Added attachment GridStatusAuras.lua.diff |
| jlam | Oct 25, 2010 at 08:13 UTC | Create |
Facts
- Last updated
- Mar 30, 2012
- Reported
- Oct 25, 2010
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Patch - Source code patch for review
- Priority
- Medium - Normal priority.
- Votes
- 6
- Reply
- #22
jlam Oct 25, 2011 at 04:12 UTC - 0 likesMy testing shows no problems and the timers were working properly in the raids I did this past week.
- Reply
- #21
jlam Oct 21, 2011 at 19:39 UTC - 0 likesAh! I'm happy to see that the patch has been integrated into the mainline Grid! Thank you very much for taking the time to review the code. I'll be checking out r1449 later tonight and will test it every which way I can.
- Reply
- #20
Phanx Oct 16, 2011 at 07:37 UTC - 0 likesAlright, it's in. Please let me know if you notice anything amiss; my testing was admittedly not very extensive.
- Reply
- #19
Phanx Oct 16, 2011 at 02:07 UTC - 0 likesAlso, there was a small bug in the logic in the CopyDefaults function:
This was causing aura statuses to be reenabled on login/reload if the user had disabled them, since the "enable" setting is a boolean with a default value of true.
Going to run around for a while... if nothing obvious pops up I'll go ahead and commit the changes.
- Reply
- #18
Phanx Oct 16, 2011 at 01:55 UTC - 0 likesWorking on merging this in right now. I'm rearranging the options a bit. I'm also adding a "Show advanced options" checkbox for the whole Auras module that will be unchecked by default; until the user checks it, they won't see these new options, or the existing class filter options. My main concern with adding your changes was the additional menu complexity, so I think keeping them out of sight of new users is a good compromise.
Also, the Grid repository is open, so once I've committed the changes, feel free to commit any bugfixes or performance tweaks you come up with in the future. I've also added you to the credits section on the front page... or well, to the readme, which will sync to become the main page once I tag the next release version. :)
- Reply
- #17
jlam Sep 23, 2011 at 20:54 UTC - 0 likesIn addition to the Grid addons I've listed in a comment below, I've found two other Grid addons whose functionality could easily be added by any Grid user with the modifications in this ticket:
- Reply
- #16
jlam Sep 23, 2011 at 20:33 UTC - 0 likesI've re-uploaded v6 of the changes to GridStatusAuras.lua. This fixes the delete buff/debuff buttons list for all of the added buffs and debuffs that was missing from the broken version of v6.
- Reply
- #15
jlam Aug 19, 2011 at 19:40 UTC - 0 likesI've just uploaded the latest patch relative to r1443 as well as the full file that can be dropped in directly to replace the one in the standard Grid distribution for those of you who don't have the tools on-hand to apply a patch.
The changes here compared to v5 are that I try to be better about memory management and cleanup. The timer refresh interval used is the smallest refresh interval requested by active status auras.
I've been using these changes for the entire Cataclysm expansion, so don't be shy about using them too.
- Reply
- #14
rach3l Aug 06, 2011 at 14:47 UTC - 0 likesThis looks like a very handy addition to grid, but for anyone who doesn't understand much about coding, the presentation is useless. I would really like to implement this. How? Do I just copy and paste the contents of GridStatusAuras.lua-v5.diff into my existing grid.lua folder? Do I make a new notepad file called GridStatusAuras.lua, paste the contents of GridStatusAuras.lua-v5.diff into it, and put the notepad file into my Grid addons folder? Please advise.
- Reply
- #13
glowang Jul 14, 2011 at 02:06 UTC - 0 likesSo how do we apply these patches ?
And this is to ADD the ability to show debuff stack count to icons on Grid correct? My Grid doesn't have the option to show Stack Count like the first picture posted on this ticket page.
I could have sworn that Grid used to give you the option to show stacks on icons at some point but it's not there anymore so I assume that's what this patch is for.